-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proper placeholder for Like and Share button #64
Comments
LGTM. @himanshub16 @gauthamzz suggestions ? |
Good... but some issues with responsiveness. @aswinzz |
i corrected it like when it is in desktop view it will as i changed and when it is in mobile view it will be the old one itself. |
@himanshub16 Let's put the responsiveness part for version 2.0 . We need to quickly fix the smaller problems now. @aswinzz Nice work. Please send a PR. |
i checked this out,it looks really weird in mobile view, the current version seems better |
@gauthamzz lets make another PR for that. the white colour. under UI improvement for that section. |
im making the PR |
@aswinzz don't remove the colour of whole page in your PR. Let me know when you are done making changes. @gauthamzz I missed your comment. |
ok ill fix it |
Needs to be placed somewhere else in the page.
and UI enhancement for both buttons.
The text was updated successfully, but these errors were encountered: