Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper placeholder for Like and Share button #64

Closed
muddlebee opened this issue Mar 20, 2017 · 10 comments
Closed

Proper placeholder for Like and Share button #64

muddlebee opened this issue Mar 20, 2017 · 10 comments

Comments

@muddlebee
Copy link
Contributor

Needs to be placed somewhere else in the page.
and UI enhancement for both buttons.

@aswinzz
Copy link
Member

aswinzz commented Mar 22, 2017

screenshot from 2017-03-22 18-45-00

Is this enough?

@muddlebee
Copy link
Contributor Author

muddlebee commented Mar 22, 2017

LGTM. @himanshub16 @gauthamzz suggestions ?

@himanshub16
Copy link
Collaborator

himanshub16 commented Mar 22, 2017

image

Good... but some issues with responsiveness. @aswinzz

@aswinzz
Copy link
Member

aswinzz commented Mar 22, 2017

i corrected it like when it is in desktop view it will as i changed and when it is in mobile view it will be the old one itself.
is that fine?
https://aswinzz.github.io/nybles.github.io/

@muddlebee muddlebee added this to the version 1.0 milestone Mar 22, 2017
@muddlebee
Copy link
Contributor Author

@himanshub16 Let's put the responsiveness part for version 2.0 . We need to quickly fix the smaller problems now.

@aswinzz Nice work. Please send a PR.

@muddlebee muddlebee added the v1 label Mar 22, 2017
@gauthamzz
Copy link
Member

i checked this out,it looks really weird in mobile view, the current version seems better
https://aswinzz.github.io/nybles.github.io/
plus its making the whole page white in color,getting rid of any distinction between header other sections

@muddlebee
Copy link
Contributor Author

@gauthamzz lets make another PR for that. the white colour. under UI improvement for that section.

@aswinzz
Copy link
Member

aswinzz commented Mar 23, 2017

im making the PR

@muddlebee
Copy link
Contributor Author

muddlebee commented Mar 23, 2017

@aswinzz don't remove the colour of whole page in your PR. Let me know when you are done making changes. @gauthamzz I missed your comment.

@aswinzz
Copy link
Member

aswinzz commented Mar 23, 2017

ok ill fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants