Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug in meteor #46

Closed
sakulstra opened this issue Oct 27, 2016 · 4 comments
Closed

bug in meteor #46

sakulstra opened this issue Oct 27, 2016 · 4 comments

Comments

@sakulstra
Copy link

Hello, thanks for this nice component.
I tried using it inside meteor, but got awkward errors(meteor/meteor#7839) cause by platform.js(bestiejs/platform.js#109)

After looking trough the react-share code i wondered why it even needs platform.js.
As far as I can see you basically only use it to check if ie < 11.
ie < 11 aren't supported any more anyways(lts has stopped and usage is below < 0.4 %), so eventually it would make sense to just also drop supporting them.

Would you accept a pr on this(drop platform.js and ie < 11 checks)?

Regards,
Lukas

@nygardk
Copy link
Owner

nygardk commented Oct 29, 2016

Hi, thanks for letting me know this. I'm certainly open to remove the dependency to platform.js, but that would need a major version bump. I'm still a bit hesitant to drop the support for IE < 11, altough you have a valid point not being used very much anymore. How does it look like, will the platform.js bug be fixed in near future? If yes, I will immediately update the dependency when it's fixed. If not, we can probably remove it.

@sakulstra
Copy link
Author

@nygardk thanks, a major bump would be great!

Actually I don't know if/when this will get merged - I did a pr on platform.js last week, but platform.js has a huge audience. A merge may need some time bestiejs/platform.js#111

@sakulstra
Copy link
Author

@nygardk - platform.js just bumped their version containing a fix to 1.3.2!

@nygardk nygardk closed this as completed in 1349a63 Nov 2, 2016
@nygardk
Copy link
Owner

nygardk commented Nov 2, 2016

Platform.js dependency updated to v1.3.2 in react-share version v1.10.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants