Whatsapp button should check if mobile #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checking if mobile, url would be 'api'. Instead in desktop browser would open 'web' whatsapp to share
aautio
requested changes
Dec 6, 2018
There was a problem hiding this comment.
Thank you @madkoding for the pull request. It seems to be working. This would help us out on multiple WhatsApp-related issues.
There are a few things where the code should be modified before merging. Would you be willing to do these changes?
-
Please execute
npm run lintto see which lines do not follow the required formatting rules. -
Please shorten and simplify the mobile/tablet detection function. The current regex on line 11 matches too many devices. According to https://faq.whatsapp.com/en/bb/26000006/ there are only 5 operating systems that would need to be checked.
This was referenced Dec 7, 2018
aautio
approved these changes
Dec 12, 2018
|
I pushed simplification to mobile/tablet check. It covers the platforms where Whatsapp is available. The code now passes eslint. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking if mobile, url would be 'api'. Instead in desktop browser would open 'web' whatsapp to share