Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add refreshing conditional class #140

Merged
merged 2 commits into from
Nov 4, 2021
Merged

Conversation

Tranced
Copy link
Contributor

@Tranced Tranced commented Oct 21, 2021

Added conditional refresh class to list items in mailboxList. Resolves #105

Readiness checklist

  • [✅ ] Cypress tests passing?
  • [❌ ] New cypress tests added?
  • [✅ ] Included before/after screenshots, if the change is visual

https://www.loom.com/share/4db0809a8c57452590f8f4a2a63fc299

License

I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@vercel
Copy link

vercel bot commented Oct 21, 2021

Someone is attempting to deploy a commit to the Nylas Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Oct 21, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nylas/components/9iQ44eumbhkPPS9Spo9SDhrUkA3y
✅ Preview: https://components-git-fork-tranced-refresh-mailbox-nylas.vercel.app

Copy link
Contributor

@heatlikeheatwave heatlikeheatwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Tranced 👋

Thank you for your contribution! I've requested a couple small changes. Let me know if you have any questions. Once you're done, re-request my review and I'll take a look.

components/mailbox/src/Mailbox.svelte Outdated Show resolved Hide resolved
components/mailbox/src/Mailbox.svelte Outdated Show resolved Hide resolved
@Tranced
Copy link
Contributor Author

Tranced commented Oct 23, 2021

@heathergh Thanks for the feedback! They're fixed :)

Copy link
Contributor

@heatlikeheatwave heatlikeheatwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making those changes! Great work, @Tranced :)

@philrenaud philrenaud merged commit 70ad168 into nylas:main Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Blur emails while reloading
3 participants