[Mailbox]: Removed query params from window url in the requests for threads #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #73576: Mailbox/Email component bug: Query params from URL are being added to request query params. |
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nylas/components/EXJqho6Wnmy8eQFX4e31fXbr7enP |
pooja169usp
requested review from
philrenaud,
a team and
arjunkalburgi
and removed request for
a team
philrenaud
approved these changes
Nov 8, 2021
pooja169usp
deleted the
poojaguggari/sc-73576/mailbox-email-component-bug-query-params
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Currently we allow filtering the threads using query parameter in the window url in addition to the
query_stringprop passed in. This can cause an issue when user app had a bunch of unrelated query parameters that will result in an error for fetching the threads. Hence removing the feature to filter the threads using window url query params.Code changes
Screenshot
Readiness checklist
License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.