Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mailbox: Variablized CSS styles #232

Merged
merged 2 commits into from
Nov 30, 2021
Merged

Conversation

AaronDDM
Copy link
Collaborator

@AaronDDM AaronDDM commented Nov 30, 2021

Code changes

  • Added a test for switching from props to forcing a network fetch of threads
  • Converted a bunch of colours and styles to css vars

License

I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #74385: Mailbox bugfixes for Components microsite.

@vercel
Copy link

vercel bot commented Nov 30, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nylas/components/3R6PGUXAbdEnTuKGtkBPAyFZjWE5
✅ Preview: https://components-git-adm-sc-74385mailbox-bugfixes-nylas.vercel.app

@AaronDDM AaronDDM force-pushed the adm/sc-74385/mailbox-bugfixes branch from 382e7c7 to 67d9879 Compare November 30, 2021 14:58
@AaronDDM AaronDDM changed the title Mailbox: Variablized CSS styles + made all_threads and keyword_to_search reactive Mailbox: Variablized CSS styles Nov 30, 2021
@AaronDDM AaronDDM requested review from a team, arjunkalburgi and pooja169usp and removed request for a team November 30, 2021 15:05
Copy link
Contributor

@pooja169usp pooja169usp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@AaronDDM AaronDDM merged commit 1f02248 into main Nov 30, 2021
@AaronDDM AaronDDM deleted the adm/sc-74385/mailbox-bugfixes branch November 30, 2021 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants