Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a test for defining replace_fields as prop & attribute to Composer #6

Merged
merged 2 commits into from
Jul 21, 2021

Conversation

pooja169usp
Copy link
Contributor

@pooja169usp pooja169usp commented Jul 20, 2021

Added a new cypress test for defining & testing replace_fields in Composer

Readiness checklist

  • Cypress tests passing
  • New cypress tests added?

image

License

I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@vercel
Copy link

vercel bot commented Jul 20, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nylas/components/8ub5CjEQ3jRyBG9ejFJDPamQ6Bst
✅ Preview: https://components-git-pg-add-test-for-composer-merge-fields-nylas.vercel.app

Copy link
Collaborator

@wonka-lighthouse wonka-lighthouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device URL
mobile http://localhost:8000/components/agenda/src/index.html

Device URL
mobile http://localhost:8000/components/composer/src/index.html

Not what you expected? Are your scores flaky? Run Lighthouse on Foo
If scores continue to be inconsistent consider running all audits on Foo

@pooja169usp pooja169usp self-assigned this Jul 21, 2021
@pooja169usp pooja169usp merged commit 75a4752 into main Jul 21, 2021
@pooja169usp pooja169usp deleted the pg/add-test-for-composer-merge-fields branch July 21, 2021 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants