[composer] Made the value prop reactive.
#93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronDDM
requested review from
ozsivanov and
heatlikeheatwave
and removed request for
a team
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nylas/components/2w7oXy8uMDsxV5auB9dHuDYiNhk8 |
|
This pull request has been linked to Shortcut Story #66489: [components-composer] Make the value prop reactive. |
ozsivanov
approved these changes
Sep 28, 2021
…y, so that is no longer supported. Pass a new object!
Comment on lines
+165
to
+168
| $: if (value) { | ||
| mergeMessage(value); | ||
| } | ||
|
|
There was a problem hiding this comment.
what's the type of value?
There was a problem hiding this comment.
Message | void but I suppose it could be undefined as well...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
valueprop could only be set at instantiation of the composer component. This prevented users from being able to change its value dynamically via JS likeelement.value = { ...newValues }.element.value.property = changeand expect any reactive changes. You must set a new object e.gelement.value = { property: change }to trigger Svelte's reactive re-render. Tests have been updated to reflect this.License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.