New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Local webhook testing support #145
Merged
mrashed-dev
merged 7 commits into
main
from
TW-1787-java-release-minor-version-with-webhook-feature
Feb 6, 2023
Merged
Local webhook testing support #145
mrashed-dev
merged 7 commits into
main
from
TW-1787-java-release-minor-version-with-webhook-feature
Feb 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add support for them in setters in the Webhook object
AaronDDM
approved these changes
Feb 6, 2023
AaronDDM
reviewed
Feb 6, 2023
AaronDDM
reviewed
Feb 6, 2023
mrashed-dev
deleted the
TW-1787-java-release-minor-version-with-webhook-feature
branch
February 6, 2023 23:16
Merged
mrashed-dev
added a commit
that referenced
this pull request
Feb 6, 2023
# Description New Nylas Java SDK release contains the following additions: * Added local webhook testing support (#145) * Added new enums for `Webhook.Triggers` and `Webhook.State` (#145) # License <!-- Your PR comment must contain the following line for us to merge the PR. --> I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.
Merged
mrashed-dev
added a commit
that referenced
this pull request
Feb 9, 2023
# Description This PR contains multiple small fixes for the Websocket implementation provided in #145: * Provide default implementations for `WebhookHandler` methods `onOpen`, `onClose`, and `onError` * Fix `Tunnel.onMessage` not emitting individual deltas * Change `java-websocket` dependency to `api` configuration # License <!-- Your PR comment must contain the following line for us to merge the PR. --> I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enables support for local webhook development. When implementing this feature in your app, the SDK will create a tunnel connection to a websocket server and registers it as a webhook callback to your Nylas account.
Usage
During the setup process you can pass in a class that implements
WebhookTunnel.WebhookHandler
with methods to override the websocket client's callback methods. The most important method is theonMessage
method which returns a parsed delta event from the webhook server.License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.