Replace Java with Kotlin + Add Auth, Calendar & Event support #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove classes absolutely not needed at the moment, create packages to organize the SDK and refactor some code
mrashed-dev
changed the title
- easier to setup - directly uses ktlint so it's akin to running it locally - doesn't deprecate java 8
AaronDDM
reviewed
Jun 21, 2023
Comment on lines
+8
to
+19
| class AddVersionHeadersInterceptor : Interceptor { | ||
| @Throws(IOException::class) | ||
| override fun intercept(chain: Interceptor.Chain): Response { | ||
| val requestBuilder = chain.request().newBuilder() | ||
| .header("User-Agent", USER_AGENT) | ||
| return chain.proceed(requestBuilder.build()) | ||
| } | ||
|
|
||
| companion object { | ||
| private val USER_AGENT = "Nylas Java SDK " + (BuildInfo.VERSION ?: "unknown") | ||
| } | ||
| } |
AaronDDM
reviewed
Jun 21, 2023
Comment on lines
236
to
247
| companion object { | ||
| const val DEFAULT_BASE_URL = "https://api-staging.us.nylas.com/" | ||
| const val EU_BASE_URL = "https://ireland.api.nylas.com/" | ||
| private fun defaultHttpClient(): OkHttpClient.Builder { | ||
| return OkHttpClient.Builder() | ||
| .connectTimeout(60, TimeUnit.SECONDS) | ||
| .readTimeout(60, TimeUnit.SECONDS) | ||
| .writeTimeout(60, TimeUnit.SECONDS) | ||
| .protocols(listOf(Protocol.HTTP_1_1)) | ||
| // .addNetworkInterceptor(HttpLoggingInterceptor()) | ||
| } | ||
| } |
There was a problem hiding this comment.
@mrashed-dev do we access this like static properties?
There was a problem hiding this comment.
@AaronDDM thanks for calling this out. This is not intended to be used by the end user, here we're stashing default values. I have updated the Regions enum to contain the different API urls and that's what the user can use to set a different URL:
NylasClient nylas = new NylasClient.Builder("API_KEY")
.baseUrl(Region.EU.getNylasApiUrl())
.build();
AaronDDM
approved these changes
Jun 21, 2023
square will preappend an empty slash if the passed in path leads with a slash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR shifts the Java SDK into a Kotlin SDK. This is done to enable friendlier support for Kotlin-powered applications while still keeping the SDK feeling native to Java, as we're designing this SDK with Java interoperability in mind. This PR also brings support for:
License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.