Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Kotlin) Rotate secret should be post #164

Merged
merged 1 commit into from Oct 25, 2023

Conversation

atejada
Copy link
Contributor

@atejada atejada commented Oct 25, 2023

License

(Kotlin) Right now rotateSecret is set as PUT method, although it should POST according to the documentation. This error gets generated when calling the method.

Exception in thread "main" java.lang.IllegalArgumentException: method PUT must have a request body.

I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

rotateSecret is currently PUT, whereas it should be POST
@atejada atejada changed the title Rotate secret should be post (Kotlin) Rotate secret should be post Oct 25, 2023
@AaronDDM AaronDDM changed the base branch from main to v2.0.0-beta October 25, 2023 15:47
@mrashed-dev mrashed-dev merged commit 95d72e9 into v2.0.0-beta Oct 25, 2023
2 checks passed
@mrashed-dev mrashed-dev deleted the rotateSecret_should_be_post branch October 25, 2023 17:40
mrashed-dev added a commit that referenced this pull request Nov 21, 2023
# Changelog

### Added
* Added support for the free-busy endpoint (#163)
* Added support for Messages, Drafts, and Smart Compose APIs (#166)
* Added support for custom authentication, connectors, and credentials
APIs (#165)
* Added support for folders API (#168)
* Added support for attachments API (#171)
* Added getter for `GetFreeBusyResponse` `object` field (#172)

### Changed
* Return webhook object with secret when creating a webhook (#162)
* Fixed HTTP method for rotating webhook secret (#164)
* Fixed Redirect URI endpoint path (#167)
* Fixed query parameter serialization (#167)
* Fixed optional field for `GetAvailabilityResponse` (#169)
* Fixed optional field for `Conferencing` (#170)

# License
<!-- Your PR comment must contain the following line for us to merge the
PR. -->
I confirm that this contribution is made under the terms of the MIT
license and that I have the authority necessary to make this
contribution on behalf of its copyright owner.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants