Change default timeout to match API (90 seconds) #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #218 +/- ##
=========================================
Coverage 78.53% 78.53%
Complexity 199 199
=========================================
Files 29 29
Lines 722 722
Branches 69 69
=========================================
Hits 567 567
Misses 117 117
Partials 38 38 ☔ View full report in Codecov by Sentry. |
AaronDDM
approved these changes
Mar 2, 2024
mrashed-dev
deleted the
TW-2712-sdk-v-3-update-default-timeout-to-90-seconds
branch
Merged
mrashed-dev
added a commit
that referenced
this pull request
Mar 5, 2024
# Changelog ### Changed * Improved message sending and draft create/update performance (#217) * Change default timeout to match API (90 seconds) (#218) # License <!-- Your PR comment must contain the following line for us to merge the PR. --> I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The API's default timeout is 90 seconds, so it's best we match that. We have updated the default value to match this, user can still override the default.
License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.