[client-sync, client-app] Remove forceWrite optimization for message …

…bodies

Summary:
It's not that much more expensive to just write the bodies while saving
to the DB in edgehill, and it's much less likely to cause unintended
side effects. E.g. this was causing empty bodies to be sent due to not
forceWrite-ing when re-saving later versions of a draft because the
local file already existed on disk.

Test Plan: Run locally, send a draft

Reviewers: evan, halla, juan

Reviewed By: juan

Differential Revision: https://phab.nylas.com/D4468

packages/client-app/src/flux/models/message.es6

@@ -109,7 +109,6 @@ export default class Message extends ModelWithMetadata {
         return MessageBodyUtils.writeBody({
           msgId: this.id,
           body: val,
-          forceWrite: false,
         });
       },
       deserializeFn: function deserializeBody(val) {

packages/isomorphic-core/src/message-body-utils.es6

@@ -37,7 +37,7 @@ export function pathForBodyFile(msgId) {
 }
 
 // NB: The return value of this function is what gets written into the database.
-export function writeBody({msgId, body, forceWrite = true} = {}) {
+export function writeBody({msgId, body} = {}) {
   const bodyPath = pathForBodyFile(msgId);
   const bodyDir = path.dirname(bodyPath);
 
@@ -63,22 +63,7 @@ export function writeBody({msgId, body, forceWrite = true} = {}) {
   }
 
   try {
-    let exists;
-
-    // If we don't have to write to the file and it already exists then don't.
-    if (!forceWrite) {
-      exists = fs.existsSync(bodyPath);
-      if (exists) {
-        return result;
-      }
-    }
-
-    // We want to minimize the number of times we interact with the filesystem
-    // since it can be slow.
-    if (exists === undefined) {
-      exists = fs.existsSync(bodyPath);
-    }
-    if (!exists) {
+    if (!fs.existsSync(bodyPath)) {
       mkdirp.sync(bodyDir);
     }