Expose 'react-addons-test-utils' for spec testing external plugins #1925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbilker
added a commit
to mbilker/cypher
that referenced
this pull request
Apr 10, 2016
|
Looks good to me—thanks! |
mbilker
added a commit
to mbilker/N1
that referenced
this pull request
Apr 13, 2016
* github/master: bump(electron): 0.36.7 => 0.37.5 Open links in background when ⌘ key is pressed (nylas#1637) fix(imports): switch to Electron's require('electron') (nylas#1907) fix(plugins): expose react-addons-test-utils for spec testing (nylas#1925) perf(require): Don't assume `require` is free, cache deferred imports bump(react) 0.14.7 => 15.0.1 fix(composer-emoji): Fix calculation for category positioning fix(emoji): Improve variable names / diff feedback changelog: 0.4.25 release notes fix(emoji): Don't allow emoji images to be dragged into attachments fix(emoji): Re-use img tag to avoid running out of file descriptors fix(metadata): Add missing joinOnField declaration, assertion fix(account-store): Allow updateAccount in all windows shrink(emoji): TinyPNG emoji, convert to 32x32 lint(utils): Fix linter issue fix(composer-emoji): Switch to characters to PNGs (nylas#1898) bump(version): 0.4.25 perf(db): Use same subselect for "related emails" queries
mbilker
added a commit
to mbilker/N1
that referenced
this pull request
Apr 13, 2016
* 'master' of github.com:mbilker/N1: (48 commits) lint(composer-emoji): eslint bump(electron): 0.36.7 => 0.37.5 Open links in background when ⌘ key is pressed (nylas#1637) fix(imports): switch to Electron's require('electron') (nylas#1907) fix(plugins): expose react-addons-test-utils for spec testing (nylas#1925) perf(require): Don't assume `require` is free, cache deferred imports bump(react) 0.14.7 => 15.0.1 fix(composer-emoji): Fix calculation for category positioning fix(emoji): Improve variable names / diff feedback changelog: 0.4.25 release notes fix(emoji): Don't allow emoji images to be dragged into attachments fix(emoji): Re-use img tag to avoid running out of file descriptors fix(metadata): Add missing joinOnField declaration, assertion fix(account-store): Allow updateAccount in all windows shrink(emoji): TinyPNG emoji, convert to 32x32 lint(utils): Fix linter issue fix(composer-emoji): Switch to characters to PNGs (nylas#1898) bump(version): 0.4.25 perf(db): Use same subselect for "related emails" queries feat(scheduler): add an event preview when sending a meeting request ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Cypher, I use
ReactTestUtilsand was exposed asReact.addons.ReactTestUtilsin React 0.13, but no longer in React 0.14. To run spec tests properly, Cypher needsReactTestUtilsexposed.This PR exposes it through
nylas-exports, but it has the side-effect of exposing it while not in dev mode. If there is a better way to expose this during spec mode, please feel free to comment.