Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typing errors in TrackingOptions and Connector #525

Merged
merged 3 commits into from
Jan 12, 2024
Merged

Fix typing errors in TrackingOptions and Connector #525

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8b8939c
Remove name field from Connector
mrashed-dev Jan 9, 2024
7ab5ede
Fix bool types for tracking options
mrashed-dev Jan 9, 2024
b8e1dc2
Update CHANGELOG.md
mrashed-dev Jan 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
* **BREAKING CHANGE**: Moved grants API out of `Auth` to `NylasClient`
* **BREAKING CHANGE**: Moved `Grants.create()` to `Auth.customAuthentication()`
* Fix issue with form-data not importing correctly for ESM projects
* Fix typing errors in TrackingOptions and Connector

### 7.0.0-beta.3 / 2023-10-23
* Added support for the messages, drafts, and threads endpoints
Expand Down
4 changes: 0 additions & 4 deletions src/models/connectors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,6 @@ import { ListQueryParams } from './listQueryParams.js';
* Interface representing the Nylas connector response.
*/
export interface Connector {
/**
* Custom name of the connector
*/
name: string;
/**
* The provider type
*/
Expand Down
6 changes: 3 additions & 3 deletions src/models/drafts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,9 @@ export type UpdateDraftRequest = Partial<CreateDraftRequest>;
*/
export interface TrackingOptions {
label?: string;
links?: string;
opens?: string;
threadReplies?: string;
links?: boolean;
opens?: boolean;
threadReplies?: boolean;
}

/**
Expand Down