Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update calendars.py #297

Closed
wants to merge 3 commits into from
Closed

Conversation

atejada
Copy link
Contributor

@atejada atejada commented Oct 23, 2023

The get_availability method is not working properly. Fixed the path and the response.

License

I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

The get_availability method is not working properly. Fixed the path and the response.
@wiseaidev
Copy link

In this case, you should remove the identifier parameter as well.

    def get_availability(
        self,
- identifier: str,
        request_body: GetAvailabilityRequest
    ) -> Response[GetAvailabilityResponse]:
        """
        Get availability for a Calendar.
        Args:
- identifier: The grant ID or email account to get availability for.
            request_body: The request body to send to the API.
        Returns:
            Response: The availability response from the API.
        """

P.S. Related to #298 for the record.

Forgot to remove "identifier"
@atejada
Copy link
Contributor Author

atejada commented Oct 23, 2023

@wiseaidev You're right. I have updated my PR. Thanks 😊

Copy link
Collaborator

@mrashed-dev mrashed-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening the PR @atejada! Left a couple of notes

nylas/resources/calendars.py Show resolved Hide resolved
Co-authored-by: Mostafa Rashed <17770919+mrashed-dev@users.noreply.github.com>
@mrashed-dev
Copy link
Collaborator

Hey @atejada I just realized that Kiran's PR (#300) which was merged includes your fix. I'm going to close this PR, thanks for the contribution!

@atejada
Copy link
Contributor Author

atejada commented Oct 27, 2023

All good 😊

@mrashed-dev mrashed-dev deleted the fix_get_availability_method_call branch January 31, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants