Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v3 Polish: Cleanup & documentation #420

Merged
merged 64 commits into from
Aug 15, 2023
Merged

v3 Polish: Cleanup & documentation #420

merged 64 commits into from
Aug 15, 2023

Commits on May 31, 2023

  1. Clean up and upgrade gemspec

    @mrashed-dev
    mrashed-dev committed May 31, 2023
    Configuration menu
    Copy the full SHA
    6b9c529 View commit details
    Browse the repository at this point in the history

  2. update webhook triggers

    @agtang96
    agtang96 committed May 31, 2023
    Configuration menu
    Copy the full SHA
    13ca571 View commit details
    Browse the repository at this point in the history

  3. protect http handlers from resources

    @agtang96
    agtang96 committed May 31, 2023
    Configuration menu
    Copy the full SHA
    4fb1fe7 View commit details
    Browse the repository at this point in the history

  4. rename api.rb to client.rb

    @mrashed-dev
    mrashed-dev committed May 31, 2023
    Configuration menu
    Copy the full SHA
    8ab3f27 View commit details
    Browse the repository at this point in the history

  5. remove unneeded gemfiles

    @mrashed-dev
    mrashed-dev committed May 31, 2023
    Configuration menu
    Copy the full SHA
    d0e93d7 View commit details
    Browse the repository at this point in the history

  6. Skeleton cleanup (#419)

    @agtang96
    agtang96 committed May 31, 2023
    Configuration menu
    Copy the full SHA
    7ea8423 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'v3-skeleton' into v3-skeleton-polish

    @mrashed-dev
    mrashed-dev committed May 31, 2023
    Configuration menu
    Copy the full SHA
    8b635c0 View commit details
    Browse the repository at this point in the history

  8. protect base resource attributes

    @mrashed-dev
    mrashed-dev committed May 31, 2023
    Configuration menu
    Copy the full SHA
    83f22ab View commit details
    Browse the repository at this point in the history

  9. Update README.md

    @mrashed-dev
    mrashed-dev committed May 31, 2023
    Configuration menu
    Copy the full SHA
    0f573d6 View commit details
    Browse the repository at this point in the history

  10. more cleanup

    @mrashed-dev
    mrashed-dev committed May 31, 2023
    Configuration menu
    Copy the full SHA
    c5447b5 View commit details
    Browse the repository at this point in the history

  11. update test

    @mrashed-dev
    mrashed-dev committed May 31, 2023
    Configuration menu
    Copy the full SHA
    5fc497a View commit details
    Browse the repository at this point in the history

  12. change response

    @agtang96
    agtang96 committed May 31, 2023
    Configuration menu
    Copy the full SHA
    c103888 View commit details
    Browse the repository at this point in the history

  13. Merge branch 'v3-skeleton' into v3-skeleton-polish

    @mrashed-dev
    mrashed-dev committed May 31, 2023
    Configuration menu
    Copy the full SHA
    adf88ba View commit details
    Browse the repository at this point in the history

  14. lint: make rubocop more bearable

    @agtang96
    agtang96 committed May 31, 2023
    Configuration menu
    Copy the full SHA
    1ab44f0 View commit details
    Browse the repository at this point in the history

  15. refactor: timeout

    @agtang96
    agtang96 committed May 31, 2023
    Configuration menu
    Copy the full SHA
    3976add View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2023

  1. Merge branch 'v3-skeleton' into v3-skeleton-polish

    @mrashed-dev
    mrashed-dev committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    d05aee2 View commit details
    Browse the repository at this point in the history

  2. Add nylas config file

    @mrashed-dev
    mrashed-dev committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    ce1cec5 View commit details
    Browse the repository at this point in the history

  3. switch to named params for config

    @mrashed-dev
    mrashed-dev committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    0f33686 View commit details
    Browse the repository at this point in the history

  4. stop tracking test.rb

    @mrashed-dev
    mrashed-dev committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    14ccf37 View commit details
    Browse the repository at this point in the history

  5. more cleanup

    @mrashed-dev
    mrashed-dev committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    110e3ee View commit details
    Browse the repository at this point in the history

  6. Cleanup gem config

    @mrashed-dev
    mrashed-dev committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    c641977 View commit details
    Browse the repository at this point in the history

  7. More readme updates

    @mrashed-dev
    mrashed-dev committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    8a1e39a View commit details
    Browse the repository at this point in the history

  8. Add yard comments to auth, application

    @mrashed-dev
    mrashed-dev committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    d669022 View commit details
    Browse the repository at this point in the history

  9. Fix typo

    @mrashed-dev
    mrashed-dev committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    9bfb1db View commit details
    Browse the repository at this point in the history

  10. Add remaining yard comments

    @mrashed-dev
    mrashed-dev committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    33c8d92 View commit details
    Browse the repository at this point in the history

  11. upgrade dependencies

    @mrashed-dev
    mrashed-dev committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    4b72adb View commit details
    Browse the repository at this point in the history

  12. Add file for yard doc generation options

    @mrashed-dev
    mrashed-dev committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    899faf8 View commit details
    Browse the repository at this point in the history

  13. cleanup

    @mrashed-dev
    mrashed-dev committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    bf437ae View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2023

  1. Exclude more files

    @mrashed-dev
    mrashed-dev committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    2c02b23 View commit details
    Browse the repository at this point in the history

  2. return true for deletes

    @mrashed-dev
    mrashed-dev committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    4b1d43a View commit details
    Browse the repository at this point in the history

  3. Cleanup errors

    @mrashed-dev
    mrashed-dev committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    d68777f View commit details
    Browse the repository at this point in the history

  4. parse v3 errors

    @mrashed-dev
    mrashed-dev committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    2954f19 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2023

  1. Move client_id and client_secret out of nylas init 

    Moved them into auth and providers where they're actually needed
    @mrashed-dev
    mrashed-dev committed Jun 3, 2023
    Configuration menu
    Copy the full SHA
    9e5c5c9 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2023

  1. move mixin logic into api operations

    @mrashed-dev
    mrashed-dev committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    bcd7fb1 View commit details
    Browse the repository at this point in the history

  2. fix error with referencing DEFAULT_REGION_URL

    @mrashed-dev
    mrashed-dev committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    c96bf12 View commit details
    Browse the repository at this point in the history

  3. rename baseresource to resource

    @mrashed-dev
    mrashed-dev committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    ffd0357 View commit details
    Browse the repository at this point in the history

  4. rename Operations -> GrantsApiOperations

    @mrashed-dev
    mrashed-dev committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    816c5ee View commit details
    Browse the repository at this point in the history

  5. cleanup

    @mrashed-dev
    mrashed-dev committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    fa6c8ad View commit details
    Browse the repository at this point in the history

  6. move v3 out of host

    @mrashed-dev
    mrashed-dev committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    70740f5 View commit details
    Browse the repository at this point in the history

  7. Introduce admin api operations

    @mrashed-dev
    mrashed-dev committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    2fac127 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2023

  1. add api operations for non-CRUD calls

    @mrashed-dev
    mrashed-dev committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    54e8b99 View commit details
    Browse the repository at this point in the history

  2. fix remaining ruby calls

    @mrashed-dev
    mrashed-dev committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    375182a View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2023

  1. set correct path

    @mrashed-dev
    mrashed-dev committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    e06701b View commit details
    Browse the repository at this point in the history

  2. should be "applications"

    @mrashed-dev
    mrashed-dev committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    76999ce View commit details
    Browse the repository at this point in the history

  3. update method name

    @mrashed-dev
    mrashed-dev committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    93190ed View commit details
    Browse the repository at this point in the history

  4. Refactor auth endpoints 

    - Remove tokeninfo endpoints
- Remove providers endpoints
- Remove 3rd party scopes
- Rename for OAuth 2 andpoints
- Rename to server side auth endpoint
    @mrashed-dev
    mrashed-dev committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    cabd22b View commit details
    Browse the repository at this point in the history

  5. fix delete operator

    @mrashed-dev
    mrashed-dev committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    14c0350 View commit details
    Browse the repository at this point in the history

  6. serialize payload before sending

    @mrashed-dev
    mrashed-dev committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    97a830e View commit details
    Browse the repository at this point in the history

  7. parse better errors

    @mrashed-dev
    mrashed-dev committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    8c901f0 View commit details
    Browse the repository at this point in the history

  8. fix url builder

    @mrashed-dev
    mrashed-dev committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    3b48936 View commit details
    Browse the repository at this point in the history

  9. fix building url

    @mrashed-dev
    mrashed-dev committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    52f8a33 View commit details
    Browse the repository at this point in the history

  10. use sym

    @mrashed-dev
    mrashed-dev committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    d59cab6 View commit details
    Browse the repository at this point in the history

  11. add missing v3

    @mrashed-dev
    mrashed-dev committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    8738e9f View commit details
    Browse the repository at this point in the history

  12. further refactor auth

    @mrashed-dev
    mrashed-dev committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    eb4db68 View commit details
    Browse the repository at this point in the history

  13. ad oauth error

    @mrashed-dev
    mrashed-dev committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    73a8172 View commit details
    Browse the repository at this point in the history

  14. do not serialize payload before calling httpclient

    @mrashed-dev
    mrashed-dev committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    398b290 View commit details
    Browse the repository at this point in the history

  15. make execute return the response from the server

    @mrashed-dev
    mrashed-dev committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    035bd54 View commit details
    Browse the repository at this point in the history

  16. switch to using execute to get raw response

    @mrashed-dev
    mrashed-dev committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    6b51c91 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2023

  1. End-of-day commit 

    - Update in-line documentation in nylas/client.rb, /config.rb, /errors.rb
- Update in-line documentation in nylas/handler/admin_api_operations.rb, /api_operations.rb, /grants_api_operations.rb, /http_client.rb
- Update in-line documentation in nylas/resources/applications.rb, /auth.rb, /calendars.rb, /events.rb, /grants.rb, /redirect_uris.rb, /resource.rb, /webhooks.rb
    @emarsh1995
    emarsh1995 committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    826dd8e View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2023

  1. End-of-day commit 

    - Update lib/nylas.rb, /errors.rb
- Update spec/nylas/api_spec.rb
- Update spec/spec_helper.rb
    @emarsh1995
    emarsh1995 committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    49de8a9 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2023

  1. End-of-day commit 

    - Update lib/nylas/config.rb, /errors.rb
- Update lib/nylas/handler/admin_api_operations.rb, /grants_api_operations.rb, /http_client.rb
- Update lib/nylas/resources/webhooks.rb
- Update spec/nylas/account_spec.rb, /api_spec.rb, /calendar_collection_spec.rb, /calendar_spec.rb, /collection_spec.rb, /component_spec.rb, /contact_group_spec.rb, /contact_spec.rb, /current_account_spec.rb, /attributes_spec.rb
    @emarsh1995
    emarsh1995 committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    7f048a4 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2023

  1. Formatting updates 

    - Update lib/nylas.rb
- Update lib/nylas/client.rb, /errors.rb
- Update lib/nylas/handler/admin_api_operations.rb, /api_operations.rb, /grants_api_operations.rb, /http_client.rb
- Update lib/nylas/resources/applications.rb, /auth.rb, /calendars.rb
- Update spec/nylas/account_spec.rb, /api_spec.rb, /calendar_collection_spec.rb, /calendar_spec.rb, /collection_spec.rb, /component_spec.rb, /contact_group_spec.rb, /contact_spec.rb, /current_account_spec.rb,
- Update spec/nylas/model/attributes_spec.rb
    @emarsh1995
    emarsh1995 committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    06f83df View commit details
    Browse the repository at this point in the history

  2. Spec documentation 

    - Update spec/nylas/delta_spec.rb, /deltas_collection_spec.rb, /deltas_spec.rb, /draft_spec.rb, /event_spec.rb, /filter_attributes_spec.rb, /folder_spec.rb, /free_busy_collection_spec.rb, /free_busy_spec.rb, /http_client_spec.rb
    @emarsh1995
    emarsh1995 committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    a4041a1 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #424 from nylas/v3-docs-polish 

    Add in-code documentation
    @emarsh1995
    emarsh1995 committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    67b3972 View commit details
    Browse the repository at this point in the history