Tw 2456 ruby add send to drafts #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding "send" to the drafts endpoint
mrashed-dev
approved these changes
Dec 20, 2023
lib/nylas/resources/drafts.rb
Outdated
Comment on lines
93
to
94
| # @param identifier [String] Grant ID or email account from which to delete an object. | ||
| # @param draft_id [String] The id of the draft to delete. |
There was a problem hiding this comment.
nit: can you update these doc lines?
Suggested change
| # @param identifier [String] Grant ID or email account from which to delete an object. | |
| # @param draft_id [String] The id of the draft to delete. | |
| # @param identifier [String] Grant ID or email account from which to send the draft. | |
| # @param draft_id [String] The id of the draft to send. |
|
Done 😅 That's the problem with copy & paste 🙃 |
|
Will merge 🥳 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Drafts endpoint on the Ruby SDK doesn’t have a Send option. This PR will add it.
https://nylas.atlassian.net/browse/TW-2456
License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.