Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Bad Links in Getting Started Docs #40

Closed
wants to merge 3 commits into from
Closed

Fixed Bad Links in Getting Started Docs #40

wants to merge 3 commits into from

Conversation

mmattioli
Copy link
Contributor

There are several bad links in the getting started docs that returned 404 pages on GitHub. Additionally, the headers weren't properly formatted. Both of these issues were rectified with proper links from the inboxapp website.

fixed fixed bad links
fixed header
changed link from http to https
@caitp
Copy link
Contributor

caitp commented Jul 11, 2014

LGTM

@caitp
Copy link
Contributor

caitp commented Jul 11, 2014

Actually you know what? These files are being preprocessed to build https://www.inboxapp.com/docs/gettingstarted, and I'm not sure if using proper markdown headings will work correctly

But the URL changes are definitely okay

@mmattioli
Copy link
Contributor Author

Those files are .mdown files and you can see in the commits how they were styled before. Properly .mdown is to either have

Title
---

or

#Title

and they had neither. I can make another commit and change it back if you want but I don't see why if that's not proper .mdown format.

@caitp
Copy link
Contributor

caitp commented Jul 12, 2014

@mmattioli I can see that they're markdown files, however it's not clear that they're being rendered exactly the same way that markdown is rendered on inboxapp.com, because as you can see, the titles are being rendered as titles there. I'm not sure which tool we're using for that, but it shouldn't be too hard to figure out if I poke through the webserver a bit. However I think it's better to wait for one of the folks in the office to take a look at it and document this somewhere.

I understand that this ("this" being the Title: ... notation) is not markdown proper, but these files are meant to be consumed via the website, and not on github. At least, as far as I can tell at this time, and when consumed from the website, they look "right".

That said, fixing the URLs is probably a good idea.

@mmattioli
Copy link
Contributor Author

@caitp I gotcha. Apologies if I came off stubborn or arrogant, I just wanted to convey my intentions and reasoning for that commit.

If you want me to make another commit to change something I'd be more than happy to :)

@mmattioli
Copy link
Contributor Author

@spang, @grinich perhaps one of you can shed some light on this? Apologies if either of you were the wrong ones to reach out to regarding this.

@grinich
Copy link
Contributor

grinich commented Jul 16, 2014

These markdown files are supposed to be read via https://www.inboxapp.com/docs and are only tracked here for convenience and versioning (if the API changes).

Were any of these links actually broken, or are these just http/https and apex domain/not changes?

@mmattioli
Copy link
Contributor Author

@grinich the links actually did not work and differ from the ones you have on your website. In addition, in #38 the CLA link doesn't work which I wanted to sign but can't since it's sorta...missing...

@mmattioli
Copy link
Contributor Author

@grinich sorry to be a pest, just wondering what the status of this is. Thanks.

@mmattioli
Copy link
Contributor Author

@spang, @grinich any sort of update on this?

@mmattioli
Copy link
Contributor Author

@spang, @grinich I'm sure you guys hate me by now but I think that you guys manually committed the changes I described in this pull. I see you've updated the CLA link so I closed #38. Should this be closed as well?

@spang
Copy link
Contributor

spang commented Jul 24, 2014

Yeah, I don't see anything else to do here. Closing, thanks.

@spang spang closed this Jul 24, 2014
@grinich
Copy link
Contributor

grinich commented Jul 24, 2014

Hi @mmattioli,

Thanks for the bugfix though! I think someone else came across these issues earlier and had a fix in the pipeline.

Please let us know if you find any other typos or have suggestions on improving the docs. Really appreciate you running through them in this detail. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants