New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Bad Links in Getting Started Docs #40
Conversation
fixed fixed bad links
fixed header
changed link from http to https
LGTM |
Actually you know what? These files are being preprocessed to build https://www.inboxapp.com/docs/gettingstarted, and I'm not sure if using proper markdown headings will work correctly But the URL changes are definitely okay |
Those files are
or
and they had neither. I can make another commit and change it back if you want but I don't see why if that's not proper |
@mmattioli I can see that they're markdown files, however it's not clear that they're being rendered exactly the same way that markdown is rendered on inboxapp.com, because as you can see, the titles are being rendered as titles there. I'm not sure which tool we're using for that, but it shouldn't be too hard to figure out if I poke through the webserver a bit. However I think it's better to wait for one of the folks in the office to take a look at it and document this somewhere. I understand that this ("this" being the That said, fixing the URLs is probably a good idea. |
@caitp I gotcha. Apologies if I came off stubborn or arrogant, I just wanted to convey my intentions and reasoning for that commit. If you want me to make another commit to change something I'd be more than happy to :) |
These markdown files are supposed to be read via https://www.inboxapp.com/docs and are only tracked here for convenience and versioning (if the API changes). Were any of these links actually broken, or are these just http/https and apex domain/not changes? |
@grinich sorry to be a pest, just wondering what the status of this is. Thanks. |
Yeah, I don't see anything else to do here. Closing, thanks. |
Hi @mmattioli, Thanks for the bugfix though! I think someone else came across these issues earlier and had a fix in the pipeline. Please let us know if you find any other typos or have suggestions on improving the docs. Really appreciate you running through them in this detail. :) |
There are several bad links in the getting started docs that returned 404 pages on GitHub. Additionally, the headers weren't properly formatted. Both of these issues were rectified with proper links from the inboxapp website.