Breakage with Tor Browser (observed from 1.0.8.6 to 1.0.10.2+)

[nym-zone]

Earlier, I installed 1.0.8.6 on Tor Browser “7.0.11 (based on Mozilla Firefox 52.5.2) (64-bit)”. The whitelisting and options UI did not work.

I tried to open the Browser Console to figure out what was happening; but the whole browser froze, spinning my CPU, and I had to kill it. Thus, I could not get any useful debug information; and I have not had time to investigate further. Also I’ve not had time to test adequately against older versions, to see if it be a regression. Apologies for the substance-starved bug report.

@whatsusername, I know that Tor Browser dislikes localstorage in its default configuration. Could that be the cause? I know that sites aren’t allowed localstorage; but I have no idea if/how that impacts add-ons.

[ghost]

Confirmed with Ff 57.03 x64 on Win 10 x64 b16299, except for the browser freeze when opening console.

Add Exception opens the pop up to either confirm or cancel, but clicking ok does not add the exception.

Clicking View Exceptions does not do not anything.

[ghost]

Yes indeed https://addons.mozilla.org/en-GB/firefox/addon/policy-control/

If active the console is showing Content Security Policy: The page's settings blocked the loading of a resource at https://0.0.0.0/cfmitm_addon

With said extension there is no option to unblock resource but one of those html elements instead:
✓ Font (@font-face)
✓ Image
✓ Media (audio and video)
✓ Object (plugin-handled content)
✓ Script (JavaScript)
✓ Stylesheet (CSS)
✓ Sub Document (iframes and frames)
✓ XMLHttpRequest
✓ Plugins
✓ WebSocket
✓ Ping
✓ Beacon

Which one to unblock?
0.0.0.0 is it like localhost?

Now having Policy Control disabled the bug is still present. The console output reading TypeError: proxy must report the same value for the non-writable, non-configurable property '"toDataURL"'

[ghost]

Meantime upgraded 1.0.9.1

Clicking View Exceptions for the first time open the add-on page alright, clicking it again does nothing and the console showing

TypeError: can't redefine non-configurable property "getElementsByName"
ObjectOrReflectDefineProperty self-hosted:4079:16 defineProperty self-hosted:4084:5

[ghost]

Add Exception appears to be working now with 1.0.9.1, even with Policy Control enabled and 0.0.0.0 not whitelisted

[nym-zone]

I tested with stock Tor Browser (in an ephemeral setup). Almost all Tor Browser settings were default; the exceptions are such matters as raising the Security Slider (actually, I preset a prefs.js entry for that). No extensions were installed, other than those which are bundled with Tor Browser.

This is the Linux distribution of Tor Browser.

[ghost]

perfect, works like a charm.

Though not part of this bug I was wondering whether with the subdomains it might confuse new users of this extension having to click several times (n = number of subdomains) until the site is finally loading. Might be worth considering to highlight/bold on the blocking site. That is just a thought since during first exposure I kept on wondering why the block page kept on reappearing.

[nym-zone]

This has been reported by others, as of 1.0.10.2 with Tor Browser:

I also don’t seem to be able to save preferences. No checked boxes or added “FQDN”s are retained upon clicking save. Are the other MITM detections functional?

Good question, that last. I think no, but I’m not sure.

I am also still experiencing this problem (although not the freeze/CPU-spin I did in 1.0.8.6).