Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean validation text #180

Merged
merged 2 commits into from
Aug 20, 2015
Merged

clean validation text #180

merged 2 commits into from
Aug 20, 2015

Conversation

TakenPilot
Copy link
Contributor

New Features

  • Ban-TK rule now finds "tktk" as well.
  • Ban-TK rule now removes elements from text, such as <em>.

@@ -1,15 +1,33 @@
var label, description,
tkText = 'TK',
searchTexts = ['TK', 'tktk'],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this look for lowercase tk as well, not just tktk?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are words with tk in them, and its an acronym for stuff, and kinds of reasons. But uppercase, or repeated? No excuse.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wait, latkes. Nevermind.

@nelsonpecora
Copy link
Contributor

👍

TakenPilot added a commit that referenced this pull request Aug 20, 2015
@TakenPilot TakenPilot merged commit 5bf1c76 into master Aug 20, 2015
@TakenPilot TakenPilot deleted the clean-validation-text branch August 20, 2015 14:31
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 83.58% when pulling 20e4962 on clean-validation-text into 3a5e6df on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants