improve selection #8

cruzanmo · 2016-08-17T16:05:53Z

Fixes #7

coveralls · 2016-08-17T16:09:36Z

Coverage increased (+0.6%) to 92.437% when pulling 512401d on improve-selection into 1224b4f on master.

davidandrewfrey · 2016-08-17T17:49:30Z

src/medium-editor-phrase.js

     * @returns {Node}
     */
-    insertTextNodePlaceholderAfter: function (node) {
-      return node.parentNode.insertBefore(this.document.createTextNode(placeholderText), node.nextSibling);
+    insertTextNodePlaceholder: function (node, after) {


coveralls · 2016-08-17T19:41:25Z

Coverage increased (+0.7%) to 92.562% when pulling cc607fa on improve-selection into 1224b4f on master.

davidandrewfrey · 2016-08-17T19:44:21Z

⭐ ⭐ ⭐ ⭐ ⭐

Nice! The convenience methods add a lot of clarity.

improve selection

512401d

davidandrewfrey reviewed Aug 17, 2016
View reviewed changes

add convenience methods

cc607fa

cruzanmo merged commit c436017 into master Aug 17, 2016

cruzanmo deleted the improve-selection branch August 17, 2016 19:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

improve selection #8

improve selection #8

cruzanmo commented Aug 17, 2016

coveralls commented Aug 17, 2016

davidandrewfrey Aug 17, 2016

coveralls commented Aug 17, 2016

davidandrewfrey commented Aug 17, 2016 •

edited

improve selection #8

improve selection #8

Conversation

cruzanmo commented Aug 17, 2016

coveralls commented Aug 17, 2016

davidandrewfrey Aug 17, 2016

Choose a reason for hiding this comment

coveralls commented Aug 17, 2016

davidandrewfrey commented Aug 17, 2016 • edited

davidandrewfrey commented Aug 17, 2016 •

edited