Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependabot security notice #267

Closed
futurechimp opened this issue Jun 17, 2020 · 1 comment
Closed

Fix dependabot security notice #267

futurechimp opened this issue Jun 17, 2020 · 1 comment

Comments

@futurechimp
Copy link
Contributor

No description provided.

@futurechimp futurechimp created this issue from a note in Core systems (Backlog) Jun 17, 2020
@futurechimp futurechimp added this to the 0.8.0 milestone Jun 17, 2020
@futurechimp
Copy link
Contributor Author

Having a look at this one, we currently have a security alert from Github in our clients/native/examples/js-examples, in the dependency websocket-extensions. Tracing through the dependencies upwards, we are depending on webpack-dev-server which uses this (about 4 layers down the stack).

The vulnerability has no effect on us (it's example code and we're not running a js-based websocket server in our examples anyway).

Since there's no effect, we can periodically check back on this one, and when we see that webpack-dev-server releases again with updated dependencies we should upgrade then.

I have no idea what happens if we just upgrade the websocket-extensions package directly in package.json and yarn.lock but I don't feel like getting into a fight with js dependency managers and finding out.

@futurechimp futurechimp removed this from the 0.8.0 milestone Jun 18, 2020
@futurechimp futurechimp moved this from Backlog to Cold Storage in Core systems Oct 14, 2020
Core systems automation moved this from Cold Storage to Done Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Core systems
  
Done
Development

No branches or pull requests

2 participants