Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to non-url-safe base64 (everywhere) #28

Closed
futurechimp opened this issue Jan 7, 2020 · 1 comment · Fixed by #102
Closed

Convert to non-url-safe base64 (everywhere) #28

futurechimp opened this issue Jan 7, 2020 · 1 comment · Fixed by #102
Assignees
Milestone

Comments

@futurechimp
Copy link
Contributor

No description provided.

@futurechimp futurechimp created this issue from a note in Core systems (Cold Storage) Jan 7, 2020
@futurechimp futurechimp added this to the 0.4.0 milestone Jan 20, 2020
@futurechimp futurechimp moved this from Cold Storage to Backlog in Core systems Jan 20, 2020
@futurechimp
Copy link
Contributor Author

The following annoying binary <--> text encodings in our codebases are Base64-URLSAFE which is inconvenient:

Sphinx

  • address encoding, eg in src/route.rs

Nym

Base64 is mostly used for key serialization (Sphinx addresses also exist):

  • identity keys
  • mixnode keys
  • Sphinx address encoding

I quite like @narodnik's idea of using Base58. It won't inflate information space like hex, but you can still read and copy/paste it conveniently and unambiguously.

@futurechimp futurechimp self-assigned this Jan 23, 2020
@futurechimp futurechimp moved this from Backlog to In progress in Core systems Jan 24, 2020
Core systems automation moved this from In progress to Done Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Core systems
  
Done
Development

Successfully merging a pull request may close this issue.

1 participant