Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of instances of Deref polymorphism antipattern #283

Closed
jstuczyn opened this issue Jul 15, 2020 · 0 comments · Fixed by #299
Closed

Get rid of instances of Deref polymorphism antipattern #283

jstuczyn opened this issue Jul 15, 2020 · 0 comments · Fixed by #299
Assignees
@jstuczyn
Projects
Core systems
Milestone
0.8.0

Comments

@jstuczyn
Copy link
Contributor

Right now I've realised I've been abusing this antipattern when dealing with aes128ctr keys. I guess an explicit call to inner() would be better.

However, I think the usage of Deref in TopologyReadPermit is fine as we really just treat it as a smart pointer, but would need to give it some thought too.

For more details refer to: the antipattern description
@jstuczyn jstuczyn added this to the 0.8.0 milestone Jul 15, 2020
@jstuczyn jstuczyn self-assigned this Jul 15, 2020
@jstuczyn jstuczyn changed the title Get rid of instance of Deref polymorphism antipattern Get rid of instances of Deref polymorphism antipattern Jul 15, 2020
@jstuczyn jstuczyn added this to Backlog in Core systems via automation Jul 15, 2020
@jstuczyn jstuczyn mentioned this issue Aug 6, 2020
Merged
Core systems automation moved this from Backlog to Done Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jstuczyn jstuczyn

Labels
None yet
Projects
Core systems
Archived in project
Core systems
  
Done
Milestone
0.8.0
Development

Successfully merging a pull request may close this issue.

Feature/reply surbs nymtech/nym
1 participant
@jstuczyn