Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle invalid base58 encoding for asymmetric key recovery (encryption and identity) #285

Closed
jstuczyn opened this issue Jul 16, 2020 · 1 comment · Fixed by #396
Closed
Assignees
Milestone

Comments

@jstuczyn
Copy link
Contributor

It seems like I have forgotten to deal with the said case and any invalid base58 string will cause a panic. For example here:

pub fn from_base58_string<S: Into<String>>(val: S) -> Result<Self, SignatureError> {
let bytes = bs58::decode(val.into())
.into_vec()
.expect("TODO: deal with this failure case");
Self::from_bytes(&bytes)

This should definitely be dealt with before another release!

@jstuczyn jstuczyn added this to the 0.8.0 milestone Jul 16, 2020
@jstuczyn jstuczyn added this to Backlog in Core systems via automation Jul 16, 2020
@futurechimp futurechimp modified the milestones: 0.8.0, 0.9.0 Sep 25, 2020
@futurechimp
Copy link
Contributor

If this is a quick one, let's do it in 0.9, if not let's push it forward into 0.10 - I think we know we have lots of these, but I'd like to get the system working end to end before dealing with them all.

@jstuczyn jstuczyn self-assigned this Oct 14, 2020
@futurechimp futurechimp modified the milestones: 0.9.0, 0.9.1 Oct 14, 2020
Core systems automation moved this from Backlog to Done Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Core systems
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants