Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the credential binary to handle transactions to sleep when in non-inProgress epochs #3057

Closed
benedettadavico opened this issue Feb 20, 2023 · 0 comments
Assignees
Milestone

Comments

@benedettadavico
Copy link
Contributor

benedettadavico commented Feb 20, 2023

Currently fails with
thread 'main' panicked at 'attempt to subtract with overflow', clients/credential/src/main.rs:55:36
Possibly an issue around the time here, as epochs might take longer than 20 seconds to advance to next one (once the expected time has been reached)
let secs_until_final = epoch.final_timestamp_secs() + 20 - current_timestamp_secs;

@benedettadavico benedettadavico created this issue from a note in Core systems (To analyse) Feb 20, 2023
@neacsu neacsu moved this from To analyse to In progress in Core systems Feb 23, 2023
@neacsu neacsu moved this from In progress to Code Review in Core systems Feb 23, 2023
@neacsu neacsu added this to the v1.1.11 milestone Feb 24, 2023
Core systems automation moved this from Code Review to Done Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Core systems
  
Done
Development

No branches or pull requests

4 participants