Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow persistently changing config values from command line #387

Closed
jstuczyn opened this issue Oct 14, 2020 · 5 comments · Fixed by #410
Closed

Allow persistently changing config values from command line #387

jstuczyn opened this issue Oct 14, 2020 · 5 comments · Fixed by #410
Assignees
Milestone

Comments

@jstuczyn
Copy link
Contributor

With introduction of #386 you are no longer allowed to initialise another node/client/gateway with the same id as an existing one. However, what if user wants to change some configuration and use it in all subsequent runs? For example he might want to change his announce-host because he updated his DNS record. If he wants to try this change once, he can already do it by simply passing --announce-host flag in run. However, if he wants always use the new value instead, he has to either manually change config.toml file or we could introduce extra flag like --save-changes in run.
Alternatively allow for flag that bypasses the check in init (I've got a feeling it would make our lives easier while developing...)

@jstuczyn jstuczyn added this to the 0.9.0 milestone Oct 14, 2020
@jstuczyn jstuczyn added this to Backlog in Core systems via automation Oct 14, 2020
@futurechimp
Copy link
Contributor

Let's talk about this, probably with Alexis who is a good proxy for a node operator, to see that we do it in the way which will be most convenient for mixnoders.

@jstuczyn
Copy link
Contributor Author

I can already say that init bypass will be very useful for us. Already run into that issue today : )

@futurechimp
Copy link
Contributor

The main thing we care about is that a re-init won't blow away the user's keys. Losing keys means that all mixnode uptime history is lost, and so is all the valuable reputation the operator has racked up. If you run a solid mixnode, people will want to stake on you. Losing your keys means that there's nothing to stake on, and it's bad news for the node operator. I think this is what we're primarily concerned about.

@futurechimp
Copy link
Contributor

I've been thinking about this some more, and to me it seems like we don't need an extra flag to achieve this (that would just make things more complex). We just want init to work like it does now, save all values etc. But if there are already keys for this id, we leave them in place rather than regenerating them.

Does this make sense?

@jstuczyn
Copy link
Contributor Author

So what you're suggesting is init with existing id would overwrite everything, but the keys (if they exist)?

@jstuczyn jstuczyn self-assigned this Nov 2, 2020
Core systems automation moved this from Backlog to Done Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Core systems
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants