Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nym-socks5-client 0.9.2 issue with outbound_request_filter.check #498

Closed
arno01 opened this issue Jan 12, 2021 · 0 comments · Fixed by #502
Closed

nym-socks5-client 0.9.2 issue with outbound_request_filter.check #498

arno01 opened this issue Jan 12, 2021 · 0 comments · Fixed by #502

Comments

@arno01
Copy link

arno01 commented Jan 12, 2021

my nym-socks5-client 0.9.2 is working only when this check is disabled:

nym$ git diff service-providers/network-requester/src/core.rs
diff --git a/service-providers/network-requester/src/core.rs b/service-providers/network-requester/src/core.rs
index 18de587..27fce2e 100644
--- a/service-providers/network-requester/src/core.rs
+++ b/service-providers/network-requester/src/core.rs
@@ -155,7 +155,7 @@ impl ServiceProvider {
     ) {
         if !self.open_proxy && !self.outbound_request_filter.check(&remote_addr) {
             log::info!("Domain {:?} failed filter check", remote_addr);
-            return;
+            // return;
         }
 
         let controller_sender_clone = controller_sender.clone();

Reproducer

1. client

$ sudo su -s /bin/sh nym -c "/home/nym/nym-client init --id jackie-chan --gateway 5nrYxPR8gt2Gzo2BbHtsGf66KAEQY91WmM1eW78EphNy"


      _ __  _   _ _ __ ___
     | '_ \| | | | '_ \ _ \
     | | | | |_| | | | | | |
     |_| |_|\__, |_| |_| |_|
            |___/

             (client - version 0.9.2)

    
Initialising client...
Saved all generated keys
Saved configuration file to "/home/nym/.nym/clients/jackie-chan/config/config.toml"
Using gateway: 5nrYxPR8gt2Gzo2BbHtsGf66KAEQY91WmM1eW78EphNy
Client configuration completed.
$ sudo su -s /bin/sh nym -c "/home/nym/nym-client run --id jackie-chan"


      _ __  _   _ _ __ ___
     | '_ \| | | | '_ \ _ \
     | | | | |_| | | | | | |
     |_| |_|\__, |_| |_| |_|
            |___/

             (client - version 0.9.2)

    
 2021-01-12T02:12:35.012 INFO  nym_client::client > Starting nym client
 2021-01-12T02:12:35.192 INFO  nym_client::client > Obtaining initial network topology from http://testnet-validator1.nymtech.net:8081
 2021-01-12T02:12:35.571 INFO  nym_client::client > Starting topology refresher...
 2021-01-12T02:12:35.572 INFO  nym_client::client > Starting received messages buffer controller...
 2021-01-12T02:12:35.671 INFO  nym_client::client > Starting mix traffic controller...
 2021-01-12T02:12:35.671 INFO  nym_client::client > Starting real traffic stream...
 2021-01-12T02:12:35.671 INFO  nym_client::client > Starting loop cover traffic stream...
 2021-01-12T02:12:35.671 INFO  nym_client::client > Starting websocket listener...
 2021-01-12T02:12:35.671 INFO  nym_client::websocket::listener > Running websocket on "127.0.0.1:1977"
 2021-01-12T02:12:35.671 INFO  nym_client::client              > Client startup finished!
 2021-01-12T02:12:35.672 INFO  nym_client::client              > The address of this client is: BzgGyWAmAdcqimFWXqiLuBNd7rKMdRRsfrKheBd8HSfA.539A9H8Zz984bUkx2WA7Sndn8PCtzsFaUQVh8HoB57vQ@5nrYxPR8gt2Gzo2BbHtsGf66KAEQY91WmM1eW78EphNy

2. network-requester

updating the whitelist:

echo "ifconfig.me" | sudo su -s /bin/sh nym -c "tee -a /home/nym/.nym/service-providers/network-requester/allowed.list"

It connects to the client over 127.0.0.1:1977 as expected.

$ sudo su -s /bin/sh nym -c "/home/nym/nym-network-requester"
Starting socks5 service provider:
 2021-01-12T02:13:39.559 INFO  nym_network_requester::core > * connected to local websocket server at ws://localhost:1977

All systems go. Press CTRL-C to stop the server.
 2021-01-12T02:14:28.330 WARN  nym_network_requester::allowed_hosts > Error parsing domain: "216.239.36.21"
 2021-01-12T02:14:28.331 INFO  nym_network_requester::core          > Domain "216.239.36.21:80" failed filter check
 2021-01-12T02:14:30.944 WARN  proxy_helpers::connection_controller > Received a 'Send' before 'Connect' - going to buffer the data

3. socks5-client

$ sudo su -s /bin/sh nym -c "~/nym-socks5-client init --id nym --gateway 5nrYxPR8gt2Gzo2BbHtsGf66KAEQY91WmM1eW78EphNy --provider BzgGyWAmAdcqimFWXqiLuBNd7rKMdRRsfrKheBd8HSfA.539A9H8Zz984bUkx2WA7Sndn8PCtzsFaUQVh8HoB57vQ@5nrYxPR8gt2Gzo2BbHtsGf66KAEQY91WmM1eW78EphNy"


      _ __  _   _ _ __ ___
     | '_ \| | | | '_ \ _ \
     | | | | |_| | | | | | |
     |_| |_|\__, |_| |_| |_|
            |___/

             (socks5 proxy - version 0.9.2)

    
Initialising client...
Saved all generated keys
Saved configuration file to "/home/nym/.nym/socks5-clients/nym/config/config.toml"
Using gateway: 5nrYxPR8gt2Gzo2BbHtsGf66KAEQY91WmM1eW78EphNy
Client configuration completed.
$ sudo su -s /bin/sh nym -c "~/nym-socks5-client run --id nym"


      _ __  _   _ _ __ ___
     | '_ \| | | | '_ \ _ \
     | | | | |_| | | | | | |
     |_| |_|\__, |_| |_| |_|
            |___/

             (socks5 proxy - version 0.9.2)

    
 2021-01-12T02:14:21.254 INFO  nym_socks5_client::client > Starting nym client
 2021-01-12T02:14:21.286 INFO  nym_socks5_client::client > Obtaining initial network topology from http://testnet-validator1.nymtech.net:8081
 2021-01-12T02:14:21.665 INFO  nym_socks5_client::client > Starting topology refresher...
 2021-01-12T02:14:21.665 INFO  nym_socks5_client::client > Starting received messages buffer controller...
 2021-01-12T02:14:21.767 INFO  nym_socks5_client::client > Starting mix traffic controller...
 2021-01-12T02:14:21.767 INFO  nym_socks5_client::client > Starting real traffic stream...
 2021-01-12T02:14:21.767 INFO  nym_socks5_client::client > Starting loop cover traffic stream...
 2021-01-12T02:14:21.767 INFO  nym_socks5_client::client > Starting socks5 listener...
 2021-01-12T02:14:21.768 INFO  nym_socks5_client::socks::server > Listening on 127.0.0.1:1080
 2021-01-12T02:14:21.768 INFO  nym_socks5_client::client        > Client startup finished!
 2021-01-12T02:14:21.768 INFO  nym_socks5_client::client        > The address of this client is: 5FDzZRoKqyZ97jJj2j7WUA9BtmDpGsPkJi6goLjF6wZJ.9iCU9ghYj7Ny4mL8K74xC7caPCmxLRtNqb1HRMW4Pxg3@5nrYxPR8gt2Gzo2BbHtsGf66KAEQY91WmM1eW78EphNy
 2021-01-12T02:14:21.768 INFO  nym_socks5_client::socks::server > Serving Connections...
 2021-01-12T02:14:25.979 INFO  nym_socks5_client::socks::client > Starting proxy for 216.239.36.21:80 (id: 18165981879384458170)

4. trying to use socks5 proxy

$ curl -v -v --socks5 127.0.0.1:1080 -LI ifconfig.me
*   Trying 127.0.0.1:1080...
* TCP_NODELAY set
* SOCKS5 communication to ifconfig.me:80
* SOCKS5 connect to IPv4 216.239.36.21:80 (locally resolved)
* SOCKS5 request granted.
* Connected to 127.0.0.1 (127.0.0.1) port 1080 (#0)
> HEAD / HTTP/1.1
> Host: ifconfig.me
> User-Agent: curl/7.68.0
> Accept: */*
> 

no reply.. it just hangs there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant