Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make validator client send as much tokens for bonding as required #614

Closed
jstuczyn opened this issue May 24, 2021 · 0 comments · Fixed by #623
Closed

Make validator client send as much tokens for bonding as required #614

jstuczyn opened this issue May 24, 2021 · 0 comments · Fixed by #623
Labels
good first issue Good for newcomers
Projects
Core systems

Comments

@jstuczyn
Copy link
Contributor

Right now our validator client sends hardcoded 100 tokens for bonding

nym/clients/validator/src/index.ts

Lines 38 to 39 in 01d7e3a

private readonly defaultGatewayBondingStake: number = 100_000000
private readonly defaultMixnodeBondingStake: number = 100_000000

However, since we can vary this amount inside our contract, the client should first query the contract state to figure out if this value has changed.
@jstuczyn jstuczyn added the good first issue Good for newcomers label May 24, 2021
@jstuczyn jstuczyn added this to the 0.10.1 milestone May 24, 2021
@jstuczyn jstuczyn added this to Backlog in Core systems via automation May 24, 2021
@jstuczyn jstuczyn modified the milestones: 0.10.1, 0.10.2 May 25, 2021
@jstuczyn jstuczyn mentioned this issue May 27, 2021
Merged
Core systems automation moved this from Backlog to Done Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
Core systems
Archived in project
Core systems
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Checking for required bond rather than using hardcoded value nymtech/nym
1 participant
@jstuczyn