Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the terrible decimal_sub_one once we update contract/validators #639

Closed
jstuczyn opened this issue Jun 14, 2021 · 0 comments · Fixed by #653
Closed

Remove the terrible decimal_sub_one once we update contract/validators #639

jstuczyn opened this issue Jun 14, 2021 · 0 comments · Fixed by #653
Projects
Core systems

Comments

@jstuczyn
Copy link
Contributor

cosmwasm v0.14.1 implements std::ops::Sub for math::Decimal meaning we will be able to get rid of the terrible workaround once we decide to update the contract (that will also require validator upgrade)

It won't get rid of all hacky operations we use, but at least it's a start.
@jstuczyn jstuczyn added this to the 0.11.0 milestone Jun 14, 2021
@jstuczyn jstuczyn added this to Backlog in Core systems via automation Jun 14, 2021
@jstuczyn jstuczyn mentioned this issue Jun 22, 2021
Merged
@futurechimp futurechimp moved this from Backlog to Cold Storage in Core systems Jun 22, 2021
Core systems automation moved this from Cold Storage to Done Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Core systems
Archived in project
Core systems
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/cosmwasm 0.14.1 update nymtech/nym
1 participant
@jstuczyn