-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install failed at the canvas@1.6.0 install script #104
Comments
I created a github account just to say: thank you! |
Hi - could someone from WNYC update the instructions to include this:
The default instructions failed on FreeBSD, so I went chasing around for that, then the OS-X instructions failed on OS-X so I installed Ubuntu in a VM and again, similar errors during the Canvas build. After a few hours, I landed on this issue and I now have this running on all 3 OSes. If this info were in the README, it would have been super helpful! |
as fix for issues nypublicradio#104 about canvas also npm 'install canvas@next' should be run
Posting this for anyone having the same issue. Since it's a local mac install, the dependency issues may not apply to other setups.
My Setup
Steps
Followed Mac OS X installation instructions in INSTALL.md (using Homebrew):
Received 15 warnings and 7 errors. Errors were for 'TryCatch' and 'HasOwnProperty' in /src/Canvas.cc:
Upgraded to Canvas 2.0.0-alpha.12
npm install canvas@next
That fixed the install errors, but when running
npm start
and trying to generate mp4, rec'd this error:A Fix
Found this issue which identifies new function: Canvas.createCanvas()
In /audiogram/audiogram/draw-frames.js, changed line 12 from
canvases.push(new Canvas(options.width, options.height));
to
canvases.push(new Canvas.createCanvas(options.width, options.height));
Not sure if the code change above should be added as a pull request since it involves Canvas 2.x - maybe a version check could switch between the two?
The text was updated successfully, but these errors were encountered: