Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrollview inside bottom sheet #1

Closed
huy-lv opened this issue Feb 11, 2019 · 17 comments
Closed

Scrollview inside bottom sheet #1

huy-lv opened this issue Feb 11, 2019 · 17 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@huy-lv
Copy link

huy-lv commented Feb 11, 2019

Hi, i have tried put a scrollview inside you bottom sheet but it didn't work fine. Could you implement this feature like the below video :D thankyou
https://photos.app.goo.gl/6FgjUm3H6SeWwTBm7

@nysamnang nysamnang added the enhancement New feature or request label Feb 12, 2019
@nysamnang
Copy link
Owner

@huy-lv Thank for giving me a feedback. I'm gonna implement it to support ScrollView as soon as possible.

@ManigandanRaamanathan
Copy link

@huy-lv was the scrollView worked or not? Quite confusing

@huylv-teko
Copy link

@ManigandanRaamanathan Sorry, it did not work, i missed a word :D

@nysamnang
Copy link
Owner

@huy-lv @ManigandanRaamanathan Currently, If you want to use a ScrollView inside RBSheet you need to set props closeOnSwipeDown to false. It works, but you just can't use swipe down gesture to close RBSheet. Honestly, it's very hard for me to implement ScrollView inside PanResponder. I spent a lot of hours but still not achieve yet. I really need a contributor who can implement this.

@huy-lv
Copy link
Author

huy-lv commented Feb 18, 2019

@nysamnang nice work, i have tried many way too but still not work :D i found some lib on github achieved that but it use native bridge. I dont want to use native bridge because i'm using Expo :D

@ManigandanRaamanathan
Copy link

ManigandanRaamanathan commented Feb 18, 2019

@huy-lv could you please share the lib name?

@ManigandanRaamanathan
Copy link

@nysamnang thanks for the idea. But having the feature without disabling the closeOnSwipeDown will be better and provides good experience for the users

@nysamnang
Copy link
Owner

@ManigandanRaamanathan Yeah, i'm trying to implement it, I'm not quitting.

@ManigandanRaamanathan
Copy link

@nysamnang great. I'll give a star for this library. It's quite rare to find such libraries for react native.

@ManigandanRaamanathan
Copy link

ManigandanRaamanathan commented Feb 18, 2019

@nysamnang The idea for scrollView is something like the facebook app comment box feature

@nysamnang
Copy link
Owner

@ManigandanRaamanathan You're right, that's my goal XD

@huy-lv
Copy link
Author

huy-lv commented Feb 18, 2019

@ManigandanRaamanathan
Copy link

ManigandanRaamanathan commented Feb 18, 2019

@huy-lv Yes that requires react-native link to make changes with the native codes. Found few people facing build errors. But this @nysamnang 's version looks clean without requiring native bridge

@nysamnang nysamnang added the wontfix This will not be worked on label Feb 25, 2019
@frattle
Copy link

frattle commented Apr 10, 2019

Hello, just a suggestion. Wouldn't it be possible to use both ScrollView and close on swipe down, if you could move listener for "draging down to close" just to bottom part of sheet?
So when closing sheet, you just swipe bottom part and body of sheet could be used as ScrollView.

EDIT: I managed to do it with simple modification of index file. Just added with small height with panresponder, so responder listen only to this small part of modal.

@nysamnang nysamnang added help wanted Extra attention is needed and removed wontfix This will not be worked on labels Oct 5, 2019
nysamnang pushed a commit that referenced this issue May 6, 2020
T4QCL T3B9 Add improvement to react-native-raw-bottom-sheet library
@j6workz
Copy link

j6workz commented Nov 27, 2020

Wrap the list items rendered inside the ScrollView with Pressable or any Touchables instead of View

It works

@dishaben9
Copy link

@j6workz It's working for me.

@NiccoloCase
Copy link

any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

8 participants