Revisions don't render code fields. Drafts do

[gbowne-quickbase]

Describe the bug

When I look at a previous revision of a page that contains a code field, it just shows as a text area. Really a low priority, but wanted to report for clarity. Thanks!

To reproduce

1. Create a page with a code field on it. Save it.
2. Make a revision or a draft. Save it and publish it
3. Look back at a previous version in the CP.

Expected behaviour

The code field would display as code with formatting, instead of a text block. Drafts seem to function just fine

Screenshots

If applicable, add screenshots to help explain your problem.
Current revision:

Previous Revision:

Draft:

Versions

• Plugin version: 4.0.10
• Craft version: 4.5.6.1

[khalwat]

So this was pretty interesting... when displaying revisions, the field's ::getStaticHtml() method is called instead of ::getInputHtml(). Code Field doesn't implement that method, so it ends up calling the parent Field method:

    /**
     * @inheritdoc
     */
    public function getStaticHtml(mixed $value, ElementInterface $element): string
    {
        // Just return the input HTML with disabled inputs by default
        Craft::$app->getView()->startJsBuffer();
        $inputHtml = $this->getInputHtml($value, $element);
        $inputHtml = preg_replace('/<(?:input|textarea|select)\s[^>]*/i', '$0 disabled', $inputHtml);
        Craft::$app->getView()->clearJsBuffer();

        return $inputHtml;
    }

...which explicitly removes any queue'd JavaScript from rendering, which then causes the Monaco editor to not be instantiated, so the formatting is never applied.

Instead, we now implement our own ::getStaticHtml() which renders the Monaco editor as readOnly so things display as intended.

Addressed in: cbae501 & cdcfda0

Craft CMS 3:

You can try it now by setting your semver in your composer.json to look like this:

    "nystudio107/craft-code-field": "dev-develop-v3 as 3.0.11”,

Then do a composer clear-cache && composer update

…..

Craft CMS 4:

You can try it now by setting your semver in your composer.json to look like this:

    "nystudio107/craft-code-field": "dev-develop-v4 as 4.0.11”,

Then do a composer clear-cache && composer update

[gbowne-quickbase]

Thanks for a quick fix, and glad it was "interesting" at least.
P.S. I'm doing your pushups for you in October

[khalwat]

How many you doing?

[gbowne-quickbase]

I’m following the pattern of Month+Day so today is 10+6. It’s a good challenge!

[khalwat]

ooooh sweet! You should carry the torch for me, and finish the entire year out! 💪