Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin's dashboard 404 overview still shows allites 404's even when site is selected #236

Closed
lexislav opened this issue May 18, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@lexislav
Copy link

Describe the bug

Retour's dashboard shows allsite's 404s even the specific site is selected.

Other issues is the clicking on 404 File Not Found URL link in 404's list leads to admindomain.cz/404url, but it should be heading to thesitethe404wasgeneratedon.com/404surl. However, clicking the plus button to handle the redirect, creates redirect on the correct site – so the correct info is there. It is just not used to generate 404 File Not Found URL link.

To reproduce

Steps to reproduce the behaviour:

  1. Change site from allsites to "somesite"
  2. See the same 404's as before

Additional step to test the other mentioned issue on dashboard:
3. click on 404url generated on other then default site

Expected behaviour

A 404's list for selected sites should be displayed?

Other improvement suggestions

The site where the 404 was generated on might be displayed in 404's list? It would be easier to navigate…

Versions

  • Plugin version: 3.1.71
  • Craft version: Craft Pro 3.7.42
  • PHP Version | 7.3.33-1
@lexislav lexislav added the bug Something isn't working label May 18, 2022
khalwat pushed a commit that referenced this issue May 18, 2022
…s down to the selected site, due to `moreParams` being saved in the object state ([#236](#236))
khalwat pushed a commit that referenced this issue May 18, 2022
…s down to the selected site, due to `moreParams` being saved in the object state ([#236](#236))
@khalwat
Copy link
Contributor

khalwat commented May 18, 2022

@khalwat khalwat closed this as completed May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants