CanonicalLink->prepForRender() - noindex detection fails for multiple meta robots values

[Abromeit]

Bug description

I have noticed that seomatic does correctly avoid issuing a canonical tag if a post is set to meta robots=noindex or meta robots=none. This is the expected behavior.

In addition, one would expect that a combined value of "noindex, nofollow" would have the same effect on the generated HTML as the value "none". That is, no canonical tag should be output.

However, if you assign more than one value to the meta robots field, e.g.

• "noindex, nofollow",
• "max-snippet:-1,noindex"
• "noarchive,noindex,notranslate"

a canonical tag will be rendered in the HTML.

To reproduce

Steps to reproduce the behaviour:

1. Make sure you're on a craft live environment or enforce the environment in the respecitve seomatic setting
2. Make sure the seomatic setting Always include canonical links regardless of environment is inactive / false
3. Create a new post / entry in your cms
4. Goto the post's SEO settings and add 2 or more values for the robots metatag
5. Save and publish the post
6. Inspect the frontend HTML result

Versions

• Plugin version: v4.0.33
• Craft version: v4.5.9

Presumed cause

In src/models/metalink/CanonicalLink.php the prepForRender() method expects the return value of $robotsArray['content'] to be an array, if multiple values were entered.

• craft-seomatic/src/models/metalink/CanonicalLink.php

  Lines 81 to 87 in a3daa47

  	$robotsArray = $robots->renderAttributes();
  	$content = $robotsArray['content'] ?? '';
  	if (!empty($content)) {
  	if (\is_array($content)) {
  	if (\in_array('noindex', $content, true) || \in_array('none', $content, true)) {
  	return false;
  	}

On my test instance i just var_dumped the value of $robotsArray['content'] and it is a string, like one that would also be used for the final output. (Like "noindex,nofollow".)

To solve this, you could probably use explode() on the string. But I suspect that there is already a more suitable solution in this project. For example, a method that can actually still return the raw array.

[khalwat]

Yeah the code was just wrong; since we render the attributes, its always going to be a string.

Addressed in: 50c4e71 & 7cd91f2

Craft CMS 3:

You can try it now by setting your semver in your composer.json to look like this:

    "nystudio107/craft-seomatic": "dev-develop as 3.4.64”,

Then do a composer clear-cache && composer update

…..

Craft CMS 4:

You can try it now by setting your semver in your composer.json to look like this:

    "nystudio107/craft-seomatic": "dev-develop-v4 as 4.0.34”,

Then do a composer clear-cache && composer update

[Abromeit]

Wow, thanks for the quick response!

But now there is the problem that no canonical tag is displayed if max-image-preview:none is included in the selected values.

craft-seomatic/buildchain/src/vue/RobotsSelect.vue

Line 41 in 5813c5c

'max-image-preview:none': Craft.t("seomatic", "No image preview is to be shown."),

craft-seomatic/src/models/metalink/CanonicalLink.php

Line 83 in 7cd91f2

if (str_contains($content, 'noindex') || str_contains($content, 'none')) {

[khalwat]

Not doing well on this one, am I? :)

Addressed in: aaf8ea4 & 8ba39a7

Craft CMS 3:

You can try it now by setting your semver in your composer.json to look like this:

    "nystudio107/craft-seomatic": "dev-develop as 3.4.64”,

Then do a composer clear-cache && composer update

…..

Craft CMS 4:

You can try it now by setting your semver in your composer.json to look like this:

    "nystudio107/craft-seomatic": "dev-develop-v4 as 4.0.34”,

Then do a composer clear-cache && composer update

[khalwat]

This working for you @Abromeit ?

[Abromeit]

@khalwat tested successfully – all fine now. 👍