New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pagination next/prev with trailing slash #1401
Comments
@khalwat ? |
Will get this addressed shortly. |
Fixed in the commits above. Craft CMS 3: You can try it now by setting your semver in your "nystudio107/craft-seomatic": "dev-develop as 3.4.73”, Then do a ….. Craft CMS 4: You can try it now by setting your semver in your "nystudio107/craft-seomatic": "dev-develop-v4 as 4.0.43”, Then do a ….. Craft CMS 5: You can try it now by setting your semver in your "nystudio107/craft-seomatic": "dev-develop-v5 as 5.0.0-beta.6”, Then do a |
Describe the bug
The pagination next/prev meta are getting a trailing slash when using
pageTrigger
with query param (eg ?page) andaddTrailingSlashesToUrls
is enabled. This due to the UrlHelper.php:L152. The passed in url already has the query param DynamicMeta.php:L102, so we end up with something likehttps://site.com/news/?page=2%2F
Expected behaviour
Trailing slash shouldn't be added to the query param.
Versions
The text was updated successfully, but these errors were encountered: