Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination next/prev with trailing slash #1401

Closed
WHITE-developer opened this issue Jan 16, 2024 · 3 comments
Closed

Pagination next/prev with trailing slash #1401

WHITE-developer opened this issue Jan 16, 2024 · 3 comments
Labels

Comments

@WHITE-developer
Copy link

Describe the bug

The pagination next/prev meta are getting a trailing slash when using pageTrigger with query param (eg ?page) and addTrailingSlashesToUrls is enabled. This due to the UrlHelper.php:L152. The passed in url already has the query param DynamicMeta.php:L102, so we end up with something like https://site.com/news/?page=2%2F

Expected behaviour

Trailing slash shouldn't be added to the query param.

Versions

  • Plugin version: 4.0.37
  • Craft version: 4.5.13
@WHITE-developer
Copy link
Author

@khalwat ?

@khalwat
Copy link
Collaborator

khalwat commented Feb 21, 2024

Will get this addressed shortly.

khalwat added a commit that referenced this issue Feb 21, 2024
…ted URL that uses URL parameters and `addTrailingSlashesToUrls` was `true` in the General config ([#1401](#1401))
khalwat added a commit that referenced this issue Feb 21, 2024
…ted URL that uses URL parameters and `addTrailingSlashesToUrls` was `true` in the General config ([#1401](#1401))
khalwat added a commit that referenced this issue Feb 21, 2024
…ted URL that uses URL parameters and `addTrailingSlashesToUrls` was `true` in the General config ([#1401](#1401))
@khalwat
Copy link
Collaborator

khalwat commented Feb 21, 2024

Fixed in the commits above.

Craft CMS 3:

You can try it now by setting your semver in your composer.json to look like this:

    "nystudio107/craft-seomatic": "dev-develop as 3.4.73”,

Then do a composer clear-cache && composer update

…..

Craft CMS 4:

You can try it now by setting your semver in your composer.json to look like this:

    "nystudio107/craft-seomatic": "dev-develop-v4 as 4.0.43”,

Then do a composer clear-cache && composer update

…..

Craft CMS 5:

You can try it now by setting your semver in your composer.json to look like this:

    "nystudio107/craft-seomatic": "dev-develop-v5 as 5.0.0-beta.6”,

Then do a composer clear-cache && composer update

@khalwat khalwat closed this as completed Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants