Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0.0-beta.2] seomatic brakes styling of color preview in card mode #1412

Closed
WHITE-developer opened this issue Feb 6, 2024 · 2 comments
Closed
Labels

Comments

@WHITE-developer
Copy link

Describe the bug

A clear and concise description of what the bug is.
The .static styling in seomatic-bxoB8j_R.css is breaking the color field styling in the card view mode
see craftcms/cms#14296

Screenshots

image
image

@khalwat
Copy link
Collaborator

khalwat commented Feb 6, 2024

Here's the culprit: https://tailwindcss.com/docs/position#statically-positioning-elements

I will fix this by prefixing my Tailwind CSS build -- something I probably should have been doing already.

khalwat added a commit to nystudio107/craft-retour that referenced this issue Feb 7, 2024
khalwat added a commit to nystudio107/craft-retour that referenced this issue Feb 7, 2024
khalwat added a commit to nystudio107/craft-retour that referenced this issue Feb 7, 2024
khalwat added a commit that referenced this issue Feb 7, 2024
…id a name collision with a Craft CSS class ([#1412](#1412))
khalwat added a commit that referenced this issue Feb 7, 2024
…id a name collision with a Craft CSS class ([#1412](#1412))
khalwat added a commit that referenced this issue Feb 7, 2024
…id a name collision with a Craft CSS class ([#1412](#1412))
@khalwat
Copy link
Collaborator

khalwat commented Feb 7, 2024

So while I still think prefixing the Tailwind CSS is the right change long-term, my initial go at refactoring it was pretty onerous, because it required trying to find only the Tailwind classes in the .twig and .vue templates, and manually adding a prefix to them.

So in the interim, I'm fixing it by just adding static to the Tailwind CSS blocklist so we don't generate that class anymore (it wasn't actually a class we used anyway).

Craft CMS 3:

You can try it now by setting your semver in your composer.json to look like this:

    "nystudio107/craft-seomatic": "dev-develop as 3.4.70”,

Then do a composer clear-cache && composer update

…..

Craft CMS 4:

You can try it now by setting your semver in your composer.json to look like this:

    "nystudio107/craft-seomatic": "dev-develop-v4 as 4.0.39”,

Then do a composer clear-cache && composer update

…..

Craft CMS 5:

You can try it now by setting your semver in your composer.json to look like this:

    "nystudio107/craft-seomatic": "dev-develop-v5 as 5.0.0-beta.3”,

Then do a composer clear-cache && composer update

@khalwat khalwat closed this as completed Feb 7, 2024
khalwat added a commit to nystudio107/craft-webperf that referenced this issue Feb 9, 2024
khalwat added a commit to nystudio107/craft-webperf that referenced this issue Feb 9, 2024
khalwat added a commit to nystudio107/craft-webperf that referenced this issue Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants