Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mergeMetaBundleSettings() needs to operate on the full array #49

Closed
khalwat opened this issue Mar 30, 2018 · 1 comment
Closed

mergeMetaBundleSettings() needs to operate on the full array #49

khalwat opened this issue Mar 30, 2018 · 1 comment
Assignees
@khalwat
Labels
bug To Do On the roadmap

Comments

@khalwat
Copy link
Collaborator

khalwat commented Mar 30, 2018

Rather than instantiating a new MetaBundle and getting its properties to update the bundle settings, mergeMetaBundleSettings() needs to operate on the raw config array.

The reason is that certain JSON-LD properties need to be stored raw, if they are converted to a model, some attributes will be pruned. Which is not what we want in a raw bundle config.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@khalwat khalwat

Labels
bug To Do On the roadmap
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@khalwat