Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breadcrumbs top level visible in Google #957

Closed
WHITE-developer opened this issue Aug 24, 2021 · 7 comments
Closed

Breadcrumbs top level visible in Google #957

WHITE-developer opened this issue Aug 24, 2021 · 7 comments
Labels

Comments

@WHITE-developer
Copy link

Breadcrumbs top level became (sometimes) visible in Google search results.
Not completely sure if it is due to the breadcrumbs as the json data seems fine.
Related issue #747

  • Plugin version: 3.3.40
  • Craft version: 3.6.11.2
khalwat added a commit that referenced this issue Aug 25, 2021
… control whether the generated JSON-LD for Breadcrumbs includes the homepage or not ([#957](#957)) & ([#747](#747))

Signed-off-by: Andrew Welch <andrew@nystudio107.com>
@khalwat
Copy link
Collaborator

khalwat commented Aug 25, 2021

Addressed in: d3d0311

You can try it now by setting your semver in your composer.json to look like this:

    "nystudio107/craft-seomatic": "dev-develop as 3.4.3”,

Then do a composer clear-cache && composer update

@khalwat khalwat closed this as completed Aug 25, 2021
@WHITE-developer
Copy link
Author

Thanks! Setting works, only the position of other items now starts at 2. Guess that should become position 1.

@khalwat
Copy link
Collaborator

khalwat commented Aug 25, 2021

Addressed in: cf6223d

You can try it now by setting your semver in your composer.json to look like this:

    "nystudio107/craft-seomatic": "dev-develop as 3.4.3”,

Then do a composer clear-cache && composer update

@WHITE-developer
Copy link
Author

Yes, looking good, thanks!

One last thing and then everything is covered I hope: on the homepage it now doesn't have any "itemListElement" anymore which makes the rich results tester complain. On the homepage the whole breadcrumbs object can be left out I guess.

(And then hope this fixes the Google indexing problem)

@khalwat
Copy link
Collaborator

khalwat commented Aug 25, 2021

hrm, I thought I handled the case of an empty https://github.com/nystudio107/craft-seomatic/blob/develop/src/helpers/DynamicMeta.php#L510

@khalwat
Copy link
Collaborator

khalwat commented Aug 25, 2021

Addressed in: c9b720e

You can try it now by setting your semver in your composer.json to look like this:

    "nystudio107/craft-seomatic": "dev-develop as 3.4.3”,

Then do a composer clear-cache && composer update

@WHITE-developer
Copy link
Author

That's it 👍, all fine now, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants