Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading to 3.4.12+ - Broken SEO Image URLs using Imgix + ImageOptimize #987

Closed
itsmattsoria opened this issue Sep 27, 2021 · 4 comments
Closed
Labels

Comments

@itsmattsoria
Copy link

After running the few updates that came out in the past few days going from version 3.4.10 to 3.4.12 I noticed that the SEO image previews in the entry editing screen in the admin in my staging environment were broken and then checked the out the metatags being generated (using automatic render enabled) were indeed pointing to the wrong URL — they were pointing to the URL of the un-transformed image at the Imgix domain I have set up using ImageOptimize, which I don't think exists and was returning a 403 error.

Locally I am not using the Imgix source and the image previews and meta tag output were working properly, showing the transformed images in the _twitterCard directory for example (I have the auto-transforms enabled for all of the SEO images in the SEOmatic settings), however on staging where I am using the Imgix source, they were broken.

I was able to pinpoint it to the 3.4.12 update after downgrading to 3.4.11 and the image URLs are correct.
As an example, the URL output for this page (https://bv.firebelly.co/who-we-are/sanjeev-krishnan) while on 3.4.12:
https://firebelly.imgix.net/uploads/circular/sanjeev-krishnan/Builders-Vision_headshot__0748.jpg

And then on 3.4.11, the correct URL:
https://firebelly.imgix.net/uploads/circular/sanjeev-krishnan/Builders-Vision_headshot__0748.jpg?auto=format&crop=focalpoint&domain=firebelly.imgix.net&fit=crop&fp-x=0.4777&fp-y=0.279&h=800&ixlib=php-3.3.0&q=82&w=800&s=b8a2f620ddb3d7caf80987d0f1a90827

That page is currently using 3.4.11 until I figure out this fix.

Any ideas on what might have changed on the version that would break this?

For some context, I'm running a multisite environment on Craft Pro 3.7.13, and I'm running ImageOptimize
1.6.36
. Again, this is only happening in the staging environment.

Thanks for your help!

@itsmattsoria
Copy link
Author

itsmattsoria commented Sep 27, 2021

Okay, after looking again I'm realizing I have two issues going on here. The first issue with the un-transformed URL being used is still an issue, but on top of that I have the fact that the URLs are getting & instead of &, which is returning a 403 error too. I think I read through another issue where someone was mentioning that happening. I'll go dig around to see if there was an answer to that.

@itsmattsoria
Copy link
Author

I did find that issue, and saw you referenced a fix for it as well: #146

Looking at this a little deeper, the images are getting the &s still, but it looks like they're being parsed just fine by Slack, Facebook, etc. Not sure if that that is unintended or not, but again, seems to be interpreted fine regardless.

khalwat pushed a commit that referenced this issue Sep 27, 2021
@khalwat
Copy link
Collaborator

khalwat commented Sep 27, 2021

Addressed in: ee91cfa

You can try it now by setting your semver in your composer.json to look like this:

    "nystudio107/craft-seomatic": "dev-develop as 3.4.14”,

Then do a composer clear-cache && composer update

@khalwat khalwat closed this as completed Sep 27, 2021
@itsmattsoria
Copy link
Author

@khalwat that seemed to do it, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants