Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect return from getCssHash() #80

Closed
raray opened this issue Feb 5, 2024 · 2 comments
Closed

Incorrect return from getCssHash() #80

raray opened this issue Feb 5, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@raray
Copy link

raray commented Feb 5, 2024

Describe the bug

As of 4.0.7, getCssHash() is incorrectly removing a section of the hash if it includes a dash. For instance, this hash is being reported as rmXHq:

"asset-src/build/main-preload.js": {
    "css": [
      "main-preload.G7-rmXHq.css"
    ],
...

This is appears to be related to changes made for nystudio107/craft-plugin-vite#21. Reverting to 4.0.6 resolves the issue.

Versions

  • Plugin version: 4.0.7
  • Craft version:4.7.0
@raray raray added the bug Something isn't working label Feb 5, 2024
@khalwat
Copy link
Contributor

khalwat commented Feb 5, 2024

What version of Vite are you using?

khalwat added a commit that referenced this issue Feb 5, 2024
khalwat added a commit that referenced this issue Feb 5, 2024
khalwat added a commit that referenced this issue Feb 5, 2024
@khalwat
Copy link
Contributor

khalwat commented Feb 5, 2024

Addressed in the commits above.

Craft CMS 3:

You can try it now by setting your semver in your composer.json to look like this:

    "nystudio107/craft-vite": "dev-develop as 1.0.34”,

Then do a composer clear-cache && composer update

…..

Craft CMS 4:

You can try it now by setting your semver in your composer.json to look like this:

    "nystudio107/craft-vite": "dev-develop-v4 as 4.0.9”,

Then do a composer clear-cache && composer update

…..

Craft CMS 5:

You can try it now by setting your semver in your composer.json to look like this:

    "nystudio107/craft-vite": "dev-develop-v5 as 5.0.0-beta.3”,

Then do a composer clear-cache && composer update

@khalwat khalwat closed this as completed Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants