Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new make command to open up a shell in the PHP container #4

Merged
merged 2 commits into from
Feb 18, 2022

Conversation

rostockahoi
Copy link
Contributor

Not much more to say about that 馃し

@khalwat
Copy link
Contributor

khalwat commented Feb 18, 2022

Thanks for the PR! I'm going to make some minor changes to this after merging it in, primarily to change it to make ssh (it's a convention I've been using elsewhere, and also the general paradigm is that I'm suffixing make with what you'd normally type to do the thing).

Also the shell command probably should be /bin/sh, and it probably should not pass along the additional commands to the container.

@khalwat khalwat merged commit 15a2576 into nystudio107:develop Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants