Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: forward errors that happened in side-effects from threads to consumers #68

Merged
merged 21 commits into from
Aug 11, 2022

Conversation

jstarpl
Copy link
Collaborator

@jstarpl jstarpl commented Jul 21, 2022

Errors that happened in a side-effect (like setTimeout or setImmediate) were not forwarded to consumers.
Also, allow users to specify a custom timeout for restarts and kills, to allow handling cases where the thread might take a bit of time to shut down.

@jstarpl jstarpl changed the title fix: forward errors from WorkerThreads to consumers fix: forward errors that happened in side-effects from threads to consumers Jul 22, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2022

Codecov Report

Merging #68 (9be3413) into master (cd379f1) will decrease coverage by 0.31%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master      #68      +/-   ##
==========================================
- Coverage   75.00%   74.68%   -0.32%     
==========================================
  Files          14       14              
  Lines        1088     1110      +22     
  Branches      251      262      +11     
==========================================
+ Hits          816      829      +13     
- Misses        270      279       +9     
  Partials        2        2              
Impacted Files Coverage Δ
src/child-process/worker.ts 74.76% <0.00%> (-1.07%) ⬇️
src/parent-process/workerPlatform/webWorkers.ts 11.11% <0.00%> (ø)
src/parent-process/manager.ts 78.07% <54.05%> (-0.62%) ⬇️
src/parent-process/workerPlatform/workerThreads.ts 80.00% <66.66%> (+1.05%) ⬆️
src/parent-process/threadedClass.ts 90.44% <100.00%> (ø)
src/shared/sharedApi.ts 95.18% <100.00%> (+0.11%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@nytamin nytamin merged commit 1f6458a into nytamin:master Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants