fix binding selectors overwriting events selectors issue #49

nytimes · Jan 17, 2013 · 8baa62d · 8baa62d
1 parent 8c3198f
commit 8baa62d
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 8,942 deletions.
diff --git a/backbone.stickit.js b/backbone.stickit.js
@@ -30,6 +30,7 @@
 				props = ['autofocus', 'autoplay', 'async', 'checked', 'controls', 'defer', 'disabled', 'hidden', 'loop', 'multiple', 'open', 'readonly', 'required', 'scoped', 'selected'];
 
 			this._modelBindings || (this._modelBindings = []);
+
 			this.unstickModel(model);
 
 			this.events || (this.events = {});
@@ -115,7 +116,7 @@
 					if (isFormEl($el) || isContenteditable($el)) {
 						// Bind events to the element which will update the model with changes.
 						_.each(config.eventsOverride || getModelEvents($el), function(type) {
-							self.events[type+' '+selector] = function() {
+							self.events[type+'.stickit '+selector] = function() {
 								var val = getElVal($el, isContenteditable($el));
 								// Don't update the model if false is returned from the `updateModel` configuration.
 								if (evaluateBoolean(self, config.updateModel, val, modelAttr))

diff --git a/test/index.html b/test/index.html
@@ -6,8 +6,8 @@
 
 	<link rel="stylesheet" href="vendor/qunit.css" type="text/css"/>  
 
-	<script type="text/javascript" src="vendor/zepto.js"></script>
-	<script type="text/javascript" src="vendor/jquery-1.6.1.js"></script>
+	<script type="text/javascript" src="http://zeptojs.com/zepto.min.js"></script>
+	<script type="text/javascript" src="http://ajax.googleapis.com/ajax/libs/jquery/1.8.3/jquery.min.js"></script>
 	<script type="text/javascript">
 		jQuery.noConflict();
 	</script>