First try at adding button support

[andriijas]

Hi

I need help with this one, if you want button support that is :)

https://github.com/andriijas/backbone.stickit/tree/buttons

The test cases I added fail, which implies there is more work to do on my changes.

For test case 1 single buttons I dont know whats wrong - the options.bindKey != bindKey check fail

For test case 2 multiple buttons I think it has to do with #62, the value of the first button is used, not the clicked one.

Thanks

[andriijas]

Hi @delambo

Tried to get my button groups going with the new handler support, first of all - genius done!

The stickit source code is much easier to grasp.

I have toyed with passing the event object to the getVal method, this way I can figure out which of the buttons that was actually clicked. This is partially related to #62 because the first $el is used, but console logging $el.length shows that it has all the correct buttons. I just cant figure out which one is the one being clicked without having access to the event object.

What do you think should that be figured out on a higher level or in handler level?

[delambo]

I like the idea of passing the event into getVal but that parameter will be inconsistent since getVal is used in updateViewBindEl at times when no event was triggered. That could be an ugly feature in the api.

You might also need to set some data into the dom, marking the current button/value to get the value when no event exists.

[andriijas]

Yeah this was what I realized as well. Haven't come up with something useful to make a pull request of yet.

[delambo]

Something stinks about this - it shouldn't be hard to set this up. The only reason why getVal is used in updateViewBindEl is to pass the original value for a bound element into afterUpdate. That's a nice-to-have, but it's probably more beneficial to pass the event into getVal.

[andriijas]

I guess this is a design decision you will have to make :)

Personally I have not used afterUpdate a lot yet, I just listen to change events on the model instead which are effectively triggered after the model has been updated.

@Listento @model, 'change:foo', @afterUpdateFooQuxBar etc

[delambo]

I think my last push to master should help. Check it out.

[andriijas]

Here is my submission to the stickit handlers store :)

Thanks for all the help @delambo

Backbone.Stickit.addHandler([
  {
    selector: '.btn-group button',
    events: ['click'],
    update: function($el, val) {
      $el.filter("[value=" + val + "]").addClass('active');
    },
    getVal: function($el, event) {
      $el.removeClass('active');
      $(event.currentTarget).addClass('active').val();
    }
  }
]);