Removing go-kit/metrics/provider to save us from dependency overload #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliver-nyt
reviewed
Feb 1, 2019
server/simple_server.go
Outdated
| }), registeredPath, r.Method, s.mets).ServeHTTP(w, r) | ||
|
|
||
| registeredPath = strings.TrimPrefix(registeredPath, "/") | ||
| prometheus.InstrumentHandler(registeredPath, |
There was a problem hiding this comment.
While you're changing this code, can you change this to use InstrumentHandlerWithOpts () with
SummaryOpts{
Subsystem: "http",
ConstLabels: Labels{"handler": handlerName},
Objectives: map[float64]float64{0.5: 0.05, 0.9: 0.01, 0.95: 0.005, 0.99: 0.001},
}
This should add the 95%tile which will give us a better comparison number as it seems like a lot of teams use 95% instead of 90%tile or 99%tile.
Danke!
There was a problem hiding this comment.
This is done. Mind taking a look and verifying its what you want?
oliver-nyt
reviewed
Feb 5, 2019
| prometheus.InstrumentHandlerWithOpts(prometheus.SummaryOpts{ | ||
| Subsystem: "http", | ||
| ConstLabels: prometheus.Labels{"handler": registeredPath}, | ||
| Objectives: map[float64]float64{0.5: 0.05, 0.9: 0.01, 0.95: 0.005, 0.99: 0.001}, |
|
🚀 🚀 🚀 🚀 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At this point in time, everyone at NYT is either using Prometheus or OpenCensus + Stackdriver (or they should be)
To save us from requiring the entire world of dependencies behind
go-kit/metrics/provider, includingmgo,influxdband all sorts of weird test clients, I'm removing:config/metricspackageserver.Config.Metricsand replacing it with 3 fields for Prometheus specificallyserver/metrics.gokit/metrics/providerin the examples.