[auth/gcp] Adding basic google web auth flow capabilities #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jprobinson
requested review from
dougdonohoe,
marwan-at-work,
oliver-nyt and
scentless-apprentice
dougdonohoe
reviewed
Sep 19, 2019
jonoden
reviewed
Sep 19, 2019
oliver-nyt
reviewed
Sep 20, 2019
jprobinson
requested review from
oliver-nyt,
dougdonohoe and
jonoden
and removed request for
marwan-at-work
jonoden
approved these changes
Sep 23, 2019
oliver-nyt
approved these changes
Sep 23, 2019
|
I haven't quite figured out a nice strategy for mocking out the whole oauth redirect. This could definitely use some tests but they may have to wait for some brave soul to tackle. |
|
Yeah, covering the whole oauth flow is tricky but there are parts of the flow you can test like e.g. the header and CustomFunction bypassing, possibly also redirect. |
|
I've added tests to cover all the non-callback scenarios. I'll poke around and see how painful those will be. |
oliver-nyt
approved these changes
Sep 23, 2019
| } | ||
|
|
||
| // use special path, expect to get through | ||
| r = httptest.NewRequest(http.MethodGet, "/bobloblaw", nil) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is bringing in my recent experimental work from github.com/jprobinson/google-webauth, which aims to ease the burden of adding the Google webauth flow to a Go server.
This comes in the form of a new "Authenticator", which manages the auth web flow but also facilitates hooks for alternate styles of service-to-service and platform authentication/authorization.
I'm going to try this out in a few of my services before bringing in, so feedback welcome!