Allow body to be empty #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows the body to be completely empty, that means without a gzip headers. This a requirement with status codes that do not allow for a body, for example 204 No Content. It also changes to a lazily initialise method for the gzip writer. Fixes #5.
|
I've updated the code to run on < Go 1.7. |
|
Ping. |
|
Sorry for the delay, we had a change of repo ownership in the past week and this fell through the gaps. This looks good to me. Thanks for contributing! |
|
Thanks for adopting this one, @jprobinson! (And sorry, @Thomasdezeeuw, for leaving you hanging.) |
jprobinson
added a commit
that referenced
this pull request
Sep 13, 2016
Adding fixes to a bug introduced with PR #16
|
Just to add an update...we found this introduced a bug for any handler calling We ended up altering the library in #19 to still allow empty responses, but only for 204 and 304. |
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows the body to be completely empty, that means without
gzip headers. This a requirement with status codes that do not allow
for a body, for example 204 No Content.
It also changes to a lazily initialise method for the gzip writer.
Fixes #5.