Fix Flush breaks response if called while buffering #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0f67f3f.
This fixes nytimes#58 and prevents the underlying Flusher from writing the wrong status code or writing headers before Content-Encoding has been set. This is cb0f3d94c6 with the test case taken from 574da8f22d.
juliens
reviewed
Nov 10, 2017
| @@ -306,21 +306,22 @@ func TestStatusCodes(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func TestStatusCodesFlushed(t *testing.T) { | |||
| func TestFlushBeforeWrite(t *testing.T) { | |||
| b := []byte(testBody) | |||
There was a problem hiding this comment.
You need to use the smallTestBody ?
There was a problem hiding this comment.
@juliens Why's that? In this test case I'm testing the interaction between Flush and Write and I want the response to be gzipped.
There was a problem hiding this comment.
Sorry I misread, I believed the write was before the flush 😉
It's good for me even though I do not really like the 'Flush` after a small body writing does not do anything.
|
Ping @jprobinson, any chance this could be reviewed/merged soon? (Sorry for the noise). |
|
🍕 thanks! ...and sorry for the wait! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the bug I noted in #58 (comment). In doing so, it reverts 0f67f3f, which was #58, and commits a different fix for that issue.
Where #58 juggled calling
WriteHeaderwithinFlush, this pull request simply makesFlusha no-op while the response is buffering, i.e. until it reaches the minimum size.In reverting 0f67f3f, it has the side-effect of reducing the size of the per-request
GzipResponseWriterstruct from 104 bytes to 96 bytes.